You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "mercyblitz (GitHub)" <gi...@apache.org> on 2019/01/16 03:18:32 UTC

[GitHub] [incubator-dubbo] mercyblitz opened pull request #3241: Merge 2.6.6 source code into 2.7

Merge 2.6.6 source code into 2.7

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

@mercyblitz  should you import the codestyle/dubbo_codestyle_for_idea.xml into idea codestyle.

The order of  org.apache.dubbo is firstly.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

Why use org.apache.dubbo package name in dubbo-compatible module?
But not com.alibaba.dubbo

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

I find the code has no diff in my local machine.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

Why change to com.alibaba but not org.apache?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on issue #3241: Merge 2.6.6 source code into 2.7

Posted by "chickenlj (GitHub)" <gi...@apache.org>.

This patch is a little too big, maybe the next time we can split them into small PRs. 
One PR solve one issue.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

Which configuration needs to use this conversion？

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

This is test for dubbo.yml but useless for dubbo-core.  It is just for fun?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] mercyblitz commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "mercyblitz (GitHub)" <gi...@apache.org>.

`ImportSelector` will register this Bean immediately, `DubboConfigConfiguration` should be deferred and wait for the `PropertySources` that are ready.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

why not use builder.append(SEPARATOR).append(value)  .

In this way , there is no need to remove last ":" in build method. 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory closed pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

[ pull request closed by cvictory ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

As above mentioned, the order should be changed 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on issue #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

I did not review the unit test. 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

As above metioned, the order should be changed 

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

ignore .  there are some code that is introduced by org.springframework.core.annotation.AnnotationUtils. 


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

It should keep consistence with logger.warn

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

questions:
1. I am not sure If we need setOrder to set.
2. is it need a default value?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

这种方式和原来ImportSelector方式比，除了简洁之外，有带来其他好处吗？

Compared with the original ImportSelector method, does this method bring other benefits besides being concise?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

I have seen the default value in setEnvironment method.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] mercyblitz commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "mercyblitz (GitHub)" <gi...@apache.org>.

This is the format of `parameters` attribute.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] mercyblitz commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "mercyblitz (GitHub)" <gi...@apache.org>.

This code has been removed, the order will be ignored in Spring Framework.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

It is no usage for other class. Why bring in this class ?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

Why introduce this setting ？ Is there a issue or give us some context to this.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj commented on issue #3241: Merge 2.6.6 source code into 2.7

Posted by "chickenlj (GitHub)" <gi...@apache.org>.

- spring-context-support去除，直接把源码加进来了
- 2.7中增加了ApplicationConfig只有一个的限制，相应的改动，主要是涉及UT
- org.apache.dubbo相关的包名改动
- https://github.com/apache/incubator-dubbo/issues/1641
- https://github.com/apache/incubator-dubbo/issues/2235
- https://github.com/apache/incubator-dubbo/issues/1654

- https://github.com/apache/incubator-dubbo/milestone/21?closed=1
- https://github.com/apache/incubator-dubbo-spring-boot-project/issues/319

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

I found is is no usage. There is no class to invoke this method.


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

Ignore this.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory closed pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

[ pull request closed by cvictory ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] mercyblitz commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "mercyblitz (GitHub)" <gi...@apache.org>.

This code has been removed, the order will be ignored in Spring Framework.



[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] mercyblitz commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "mercyblitz (GitHub)" <gi...@apache.org>.

My IDEA is using the `codestyle/dubbo_codestyle_for_idea.xml` as a code style template.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3241: Merge 2.6.6 source code into 2.7

Posted by "codecov-io (GitHub)" <gi...@apache.org>.

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3241?src=pr&el=h1) Report
> Merging [#3241](https://codecov.io/gh/apache/incubator-dubbo/pull/3241?src=pr&el=desc) into [2.7.0-release](https://codecov.io/gh/apache/incubator-dubbo/commit/5acb4bf8686a6c315d8f2f3754f3635909208ab4?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `63.24%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3241?src=pr&el=tree)

```diff
@@                 Coverage Diff                 @@
##             2.7.0-release    #3241      +/-   ##
===================================================
- Coverage            63.79%   63.72%   -0.08%     
  Complexity              75       75              
===================================================
  Files                  654      658       +4     
  Lines                28386    28579     +193     
  Branches              4809     4837      +28     
===================================================
+ Hits                 18110    18212     +102     
- Misses                7993     8092      +99     
+ Partials              2283     2275       -8
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3241?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/context/annotation/DubboConfigConfiguration.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvbi5qYXZh) | `66.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...nnotation/DubboConfigBindingBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQmluZGluZ0JlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `67.5% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ory/annotation/CompatibleReferenceBeanBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vY29uZmlnL3NwcmluZy9iZWFucy9mYWN0b3J5L2Fubm90YXRpb24vQ29tcGF0aWJsZVJlZmVyZW5jZUJlYW5CdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/apache/dubbo/config/spring/util/ObjectUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9PYmplY3RVdGlscy5qYXZh) | `50% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...g/context/properties/DefaultDubboConfigBinder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9wcm9wZXJ0aWVzL0RlZmF1bHREdWJib0NvbmZpZ0JpbmRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ontext/annotation/DubboConfigBindingRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQmluZGluZ1JlZ2lzdHJhci5qYXZh) | `92.72% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ans/factory/annotation/ServiceBeanNameBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1NlcnZpY2VCZWFuTmFtZUJ1aWxkZXIuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [...nnotation/AbstractAnnotationConfigBeanBuilder.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL0Fic3RyYWN0QW5ub3RhdGlvbkNvbmZpZ0JlYW5CdWlsZGVyLmphdmE=) | `93.33% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...spring/context/event/ServiceBeanExportedEvent.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9TZXJ2aWNlQmVhbkV4cG9ydGVkRXZlbnQuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | |
| [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
| ... and [45 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3241/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3241?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3241?src=pr&el=footer). Last update [5acb4bf...7eda952](https://codecov.io/gh/apache/incubator-dubbo/pull/3241?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

I find the code has no diff

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cvictory commented on pull request #3241: Merge 2.6.6 source code into 2.7

Posted by "cvictory (GitHub)" <gi...@apache.org>.

why?

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3241 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org