You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "clintropolis (via GitHub)" <gi...@apache.org> on 2024/09/19 01:10:33 UTC
[PR] hard-code compaction tasks to use ARRAY for multi-value handling to preserve order (druid)
clintropolis opened a new pull request, #17110:
URL: https://github.com/apache/druid/pull/17110
Changes compaction tasks to always use `MultiValueHandling.ARRAY` if the column schema is not explicitly specified. This should be safe because it will just preserve whatever order the values in the row were stored in on the initial ingestion, and not re-order the values if initially ingested as unordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] hard-code compaction tasks to use ARRAY for multi-value handling to preserve order (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on code in PR #17110:
URL: https://github.com/apache/druid/pull/17110#discussion_r1766107506
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -989,9 +990,13 @@ private void processDimensionsSpec(final QueryableIndex index)
// column for it.
final ColumnHolder columnHolder = index.getColumnHolder(dimension);
if (columnHolder != null) {
+ DimensionSchema schema = columnHolder.getColumnFormat().getColumnSchema(dimension);
+ if (schema instanceof StringDimensionSchema) {
Review Comment:
A comment about why this is happening would be useful. It probably won't be obvious to a reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] hard-code compaction tasks to use ARRAY for multi-value handling to preserve order (druid)
Posted by "clintropolis (via GitHub)" <gi...@apache.org>.
clintropolis merged PR #17110:
URL: https://github.com/apache/druid/pull/17110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org