You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/03 02:02:56 UTC
[GitHub] [airflow] bphillips-exos opened a new pull request #7013:
[AIRFLOW-6434] Add return back to DockerOperator.execute
bphillips-exos opened a new pull request #7013: [AIRFLOW-6434] Add return back to DockerOperator.execute
URL: https://github.com/apache/airflow/pull/7013
https://issues.apache.org/jira/browse/AIRFLOW-6434
This change (https://github.com/apache/airflow/commit/8a6dc6657d2a32ac3979e6478512d518ad5a5212) introduced a slight (and I believe unintended) change to the Docker Operator xcom behavior. Even if xcom_push is True, DockerOperator.execute will not return a value and thus will not push an xcom value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7013: [AIRFLOW-6434] Add
return back to DockerOperator.execute
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7013: [AIRFLOW-6434] Add return back to DockerOperator.execute
URL: https://github.com/apache/airflow/pull/7013#issuecomment-570543562
Can you add tests to prevent regression?
Information about writing tests is available:
https://github.com/apache/airflow/blob/master/TESTING.rst
Information about development environment:
https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7013: [AIRFLOW-6434] Add
return back to DockerOperator.execute
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7013: [AIRFLOW-6434] Add return back to DockerOperator.execute
URL: https://github.com/apache/airflow/pull/7013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] bphillips-exos commented on issue #7013: [AIRFLOW-6434]
Add return back to DockerOperator.execute
Posted by GitBox <gi...@apache.org>.
bphillips-exos commented on issue #7013: [AIRFLOW-6434] Add return back to DockerOperator.execute
URL: https://github.com/apache/airflow/pull/7013#issuecomment-570623542
@mik-laj added a test for expected behavior
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services