[GitHub] [nuttx] behappy1234 commented on pull request #10318: Cordic api modify

["behappy1234 (via GitHub)" <gi...@apache.org>]

behappy1234 commented on PR #10318:
URL: https://github.com/apache/nuttx/pull/10318#issuecomment-1685749547

   > Response from the old PR [#10282 (comment)](https://github.com/apache/nuttx/pull/10282#issuecomment-1685518888)
   > 
   > > Yes, the numerical type for q1.15 is as a default here. I do this, because if I open for MATH_FFT, then math.c is compiled, so cordic.h is included and CONFIG_MATH_CORDIC_USE_Q31 is needed for cordic_num_t to be configed even in this case I don't need to care about cordic. So, CONFIG_MATH_CORDIC_USE_Q31 is "redundant" here, or a default cordic_num_t definition is need. And I remove it as a default one.
   > 
   > If you don't need cordic, then why just not guard all cordic logic with `#ifdef CONFIG_MATH_CORDIC` ? The same applies to the FFT.
   
   understood


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org