You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Gordon Sim <gs...@redhat.com> on 2013/11/21 11:25:33 UTC
Review Request 15757: detect and warn when two brokers use the same
federation tag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15757/
-----------------------------------------------------------
Review request for qpid.
Repository: qpid
Description
-------
as this can affect routing, see e.g. http://qpid.2158936.n2.nabble.com/routing-messages-with-qpid-route-td7600745.html
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1543019
Diff: https://reviews.apache.org/r/15757/diff/
Testing
-------
Thanks,
Gordon Sim
Re: Review Request 15757: detect and warn when two brokers use the same
federation tag
Posted by Gordon Sim <gs...@redhat.com>.
> On Nov. 21, 2013, 2:38 p.m., Ted Ross wrote:
> > This change is valuable and will provide *some* protection against having more than one broker with the same federation tag. However, there are still pathological cases this will not detect. For example: A - B - A - C. Since no two brokers with the same tag are connected, the problem will not be detected.
Good point. Perhaps some way of simply detecting when the same tag is used in conjunction with a different local host name and/or port and warning about that might be possible(?).
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15757/#review29226
-----------------------------------------------------------
On Nov. 21, 2013, 10:27 a.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15757/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 10:27 a.m.)
>
>
> Review request for qpid.
>
>
> Bugs: QPID-5370
> https://issues.apache.org/jira/browse/QPID-5370
>
>
> Repository: qpid
>
>
> Description
> -------
>
> as this can affect routing, see e.g. http://qpid.2158936.n2.nabble.com/routing-messages-with-qpid-route-td7600745.html
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1543019
>
> Diff: https://reviews.apache.org/r/15757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 15757: detect and warn when two brokers use the same
federation tag
Posted by Ted Ross <tr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15757/#review29226
-----------------------------------------------------------
Ship it!
This change is valuable and will provide *some* protection against having more than one broker with the same federation tag. However, there are still pathological cases this will not detect. For example: A - B - A - C. Since no two brokers with the same tag are connected, the problem will not be detected.
- Ted Ross
On Nov. 21, 2013, 5:27 a.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15757/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 5:27 a.m.)
>
>
> Review request for qpid.
>
>
> Bugs: QPID-5370
> https://issues.apache.org/jira/browse/QPID-5370
>
>
> Repository: qpid
>
>
> Description
> -------
>
> as this can affect routing, see e.g. http://qpid.2158936.n2.nabble.com/routing-messages-with-qpid-route-td7600745.html
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1543019
>
> Diff: https://reviews.apache.org/r/15757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 15757: detect and warn when two brokers use the same
federation tag
Posted by Gordon Sim <gs...@redhat.com>.
> On Nov. 21, 2013, 2:03 p.m., Kenneth Giusti wrote:
> > We should include this in 0.26, IMHO. Also, wouldn't such a configuration problem be significant enough to warrant a log level of type "Error" rather than warning, since the related feature (federation) really would not function properly?
> >
Yes, you are right.
- Gordon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15757/#review29225
-----------------------------------------------------------
On Nov. 21, 2013, 10:27 a.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15757/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 10:27 a.m.)
>
>
> Review request for qpid.
>
>
> Bugs: QPID-5370
> https://issues.apache.org/jira/browse/QPID-5370
>
>
> Repository: qpid
>
>
> Description
> -------
>
> as this can affect routing, see e.g. http://qpid.2158936.n2.nabble.com/routing-messages-with-qpid-route-td7600745.html
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1543019
>
> Diff: https://reviews.apache.org/r/15757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 15757: detect and warn when two brokers use the same
federation tag
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15757/#review29225
-----------------------------------------------------------
Ship it!
We should include this in 0.26, IMHO. Also, wouldn't such a configuration problem be significant enough to warrant a log level of type "Error" rather than warning, since the related feature (federation) really would not function properly?
- Kenneth Giusti
On Nov. 21, 2013, 10:27 a.m., Gordon Sim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15757/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2013, 10:27 a.m.)
>
>
> Review request for qpid.
>
>
> Bugs: QPID-5370
> https://issues.apache.org/jira/browse/QPID-5370
>
>
> Repository: qpid
>
>
> Description
> -------
>
> as this can affect routing, see e.g. http://qpid.2158936.n2.nabble.com/routing-messages-with-qpid-route-td7600745.html
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1543019
>
> Diff: https://reviews.apache.org/r/15757/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gordon Sim
>
>
Re: Review Request 15757: detect and warn when two brokers use the same
federation tag
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15757/
-----------------------------------------------------------
(Updated Nov. 21, 2013, 10:27 a.m.)
Review request for qpid.
Bugs: QPID-5370
https://issues.apache.org/jira/browse/QPID-5370
Repository: qpid
Description
-------
as this can affect routing, see e.g. http://qpid.2158936.n2.nabble.com/routing-messages-with-qpid-route-td7600745.html
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/ConnectionHandler.cpp 1543019
Diff: https://reviews.apache.org/r/15757/diff/
Testing
-------
Thanks,
Gordon Sim