[jira] [Commented] (SPARK-26896) Add maven profiles for running tests with JDK 11

["Sean Owen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-26896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782096#comment-16782096 ] 

Sean Owen commented on SPARK-26896:
-----------------------------------

Reproducing my comments from elsewhere: I don't think we want to have users set flags to get Spark to run if at all possible. So far, haven't seen something that we can't work around 'correctly', but we haven't finished finding all the issues.

We'd always build with Java 8 BTW until Java 8 support is dropped. I agree we might need a new profile just for tests if it's needed to set java.version or something, but hopefully not flags.

> Add maven profiles for running tests with JDK 11
> ------------------------------------------------
>
>                 Key: SPARK-26896
>                 URL: https://issues.apache.org/jira/browse/SPARK-26896
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Build
>    Affects Versions: 3.0.0
>            Reporter: Imran Rashid
>            Priority: Major
>
> Running unit tests w/ JDK 11 trips over some issues w/ the new module system.  These can be worked around with the new {{--add-opens}} etc. commands.  I think we need to add a build profile for JDK 11 to add some extra args to the test runners.
> In particular:
> 1) removal of jaxb from java itself (used in pmml export in mllib)
> 2) Some reflective access which results in failures, eg. 
> {noformat}
> Unable to make field jdk.internal.ref.PhantomCleanable
> jdk.internal.ref.PhantomCleanable.prev accessible: module java.base does
> not "opens jdk.internal.ref" to unnamed module
> {noformat}
> 3) Some reflective access which results in warnings (you can add {{--illegal-access=warn}} to see all of these).
> All I'm proposing we do here is put in the required handling to make these problems go away, not necessarily do the "right" thing by no longer referencing these unexposed internals.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org