You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bh...@apache.org on 2020/08/11 00:36:19 UTC
[hbase] branch branch-2.3 updated (7c52684 -> 15d9ae5)
This is an automated email from the ASF dual-hosted git repository.
bharathv pushed a change to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git.
from 7c52684 HBASE-24835 Normalizer should log a successful run at INFO level
new 9f64fe2 Revert "HBASE-21905 (addendum): Address compaction races in TestFIFOCompactionPolicy (#2203)"
new 15d9ae5 HBASE-24846: Address compaction races in TestFIFOCompactionPolicy (#2203)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
[hbase] 01/02: Revert "HBASE-21905 (addendum): Address compaction
races in TestFIFOCompactionPolicy (#2203)"
Posted by bh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
bharathv pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 9f64fe2f79ad9067898778b0ebad318ef03aa0d7
Author: Bharath Vissapragada <bh...@apache.org>
AuthorDate: Mon Aug 10 17:29:56 2020 -0700
Revert "HBASE-21905 (addendum): Address compaction races in TestFIFOCompactionPolicy (#2203)"
This reverts commit c6744c0a8b3b4b6568f59ee651ce1b51ffbfd4a0.
Reverting to apply as HBASE-24846.
---
.../hbase/regionserver/compactions/TestFIFOCompactionPolicy.java | 5 -----
1 file changed, 5 deletions(-)
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
index 9fee333..36afd84 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
@@ -122,11 +122,6 @@ public class TestFIFOCompactionPolicy {
EnvironmentEdgeManager.injectEdge(ee);
Configuration conf = TEST_UTIL.getConfiguration();
conf.setInt(HStore.BLOCKING_STOREFILES_KEY, 10000);
- // Expired store file deletion during compaction optimization interferes with the FIFO
- // compaction policy. The race causes changes to in-flight-compaction files resulting in a
- // non-deterministic number of files selected by compaction policy. Disables that optimization
- // for this test run.
- conf.setBoolean("hbase.store.delete.expired.storefile", false);
TEST_UTIL.startMiniCluster(1);
}
[hbase] 02/02: HBASE-24846: Address compaction races in
TestFIFOCompactionPolicy (#2203)
Posted by bh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
bharathv pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git
commit 15d9ae59c124b1e07e13dc707e1b8b8978ccf990
Author: Bharath Vissapragada <bh...@apache.org>
AuthorDate: Thu Aug 6 09:31:41 2020 -0700
HBASE-24846: Address compaction races in TestFIFOCompactionPolicy (#2203)
Looped through the test 100 times and it passes. Without the patch it fails
every ~10 runs or so.
Signed-off-by: Viraj Jasani <vj...@apache.org>
Signed-off-by: Michael Stack <st...@apache.org>
---
.../hbase/regionserver/compactions/TestFIFOCompactionPolicy.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
index 36afd84..9fee333 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestFIFOCompactionPolicy.java
@@ -122,6 +122,11 @@ public class TestFIFOCompactionPolicy {
EnvironmentEdgeManager.injectEdge(ee);
Configuration conf = TEST_UTIL.getConfiguration();
conf.setInt(HStore.BLOCKING_STOREFILES_KEY, 10000);
+ // Expired store file deletion during compaction optimization interferes with the FIFO
+ // compaction policy. The race causes changes to in-flight-compaction files resulting in a
+ // non-deterministic number of files selected by compaction policy. Disables that optimization
+ // for this test run.
+ conf.setBoolean("hbase.store.delete.expired.storefile", false);
TEST_UTIL.startMiniCluster(1);
}