You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "cmcfarlen (via GitHub)" <gi...@apache.org> on 2023/10/30 18:52:14 UTC
[PR] cmake: resolve install prefix later to pickup prefix override [trafficserver]
cmcfarlen opened a new pull request, #10693:
URL: https://github.com/apache/trafficserver/pull/10693
If you `cmake --install <build> --prefix <prefix>` then the default config files were installed to the wrong place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: resolve install prefix later to pickup prefix override [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #10693:
URL: https://github.com/apache/trafficserver/pull/10693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] cmake: resolve install prefix later to pickup prefix override [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #10693:
URL: https://github.com/apache/trafficserver/pull/10693#discussion_r1376755121
##########
cmake/install_configs.cmake:
##########
@@ -22,11 +22,12 @@
file(GLOB CONFIG_FILES ${CONFIG_SOURCE_GLOBS})
-file(MAKE_DIRECTORY $ENV{DESTDIR}${CONFIG_DEST_PATH})
+file(MAKE_DIRECTORY $ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}${CONFIG_DEST_PATH})
Review Comment:
Does the argument here need to be quoted now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org