[GitHub] JBevillC commented on issue #3181: TO API - DeliveryServices AddSSLKeys Incorrectly stores X509 certificate missing Subject/Authority Key as zero length string.

[GitBox <gi...@apache.org>]

JBevillC commented on issue #3181: TO API - DeliveryServices AddSSLKeys Incorrectly stores X509 certificate missing Subject/Authority Key as zero length string.
URL: https://github.com/apache/trafficcontrol/issues/3181#issuecomment-451286364
 
 
   From trafficops_golang/deliveryservices/keys.go: https://github.com/apache/trafficcontrol/blob/master/traffic_ops/traffic_ops_golang/deliveryservice/keys.go#L328-L335
   pemEncodedChain remains as a zero length string if all certificates submitted for import are  missing the Subjective/Authority Key Indicator X509v3 metadata.:
   ```
    	pemEncodedChain := ""
   	for _, link := range chain[0] {
   		// Only print non-self signed elements of the chain
   		if link.AuthorityKeyId != nil && !bytes.Equal(link.AuthorityKeyId, link.SubjectKeyId) {
   			block := &pem.Block{Type: "CERTIFICATE", Bytes: link.Raw}
   			pemEncodedChain += string(pem.EncodeToMemory(block))
   		}
   	}
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services