You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/02/16 19:56:27 UTC
[GitHub] [maven] oopexpert opened a new pull request #328: [Refactoring]
extract methods, apply SLA in PluginDescriptorBuilder
oopexpert opened a new pull request #328: [Refactoring] extract methods, apply SLA in PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328
The build method of the class ""PluginDescriptorBuilder" was very long.
I extracted several methods and harmonized the methodolgy to set all values. It now follows the strict concept: extracting the necessary element from the PlexusConfiguration and setting it on the PluginDescriptor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] khmarbaise commented on issue #328: [MNG-6866] extract
methods, apply SLA in PluginDescriptorBuilder
Posted by GitBox <gi...@apache.org>.
khmarbaise commented on issue #328: [MNG-6866] extract methods, apply SLA in PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328#issuecomment-596692334
Lets see what CI says...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] khmarbaise closed pull request #328: [MNG-6866] extract
methods, apply SLA in PluginDescriptorBuilder
Posted by GitBox <gi...@apache.org>.
khmarbaise closed pull request #328: [MNG-6866] extract methods, apply SLA in PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on issue #328: [MNG-6866] extract
methods, apply SLA in PluginDescriptorBuilder
Posted by GitBox <gi...@apache.org>.
oopexpert commented on issue #328: [MNG-6866] extract methods, apply SLA in PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328#issuecomment-596801475
looks green to me...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] khmarbaise commented on issue #328: [MNG-6866] extract
methods, apply SLA in PluginDescriptorBuilder
Posted by GitBox <gi...@apache.org>.
khmarbaise commented on issue #328: [MNG-6866] extract methods, apply SLA in PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328#issuecomment-605680645
Merged to master. Thanks for your contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] khmarbaise edited a comment on issue #328: [MNG-6866]
extract methods, apply SLA in PluginDescriptorBuilder
Posted by GitBox <gi...@apache.org>.
khmarbaise edited a comment on issue #328: [MNG-6866] extract methods, apply SLA in PluginDescriptorBuilder
URL: https://github.com/apache/maven/pull/328#issuecomment-596692334
Lets see what CI says...https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6866/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services