You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/06 00:36:07 UTC

[GitHub] [arrow] karldw opened a new pull request #11334: ARROW-14210: [C++] Add AR and RANLIB flags to bzip2

karldw opened a new pull request #11334:
URL: https://github.com/apache/arrow/pull/11334


   Is this right? I passed these as `AR=` and `RANLIB=` instead of `-DCMAKE_AR=` and `-DCMAKE_RANLIB=`. It seems like `BZIP2_EXTRA_ARGS` gets passed straight to `make`.
   
   I did:
   ```cmake
     if(CMAKE_AR)
       list(APPEND BZIP2_EXTRA_ARGS AR=${CMAKE_AR})
     endif()
   
     if(CMAKE_RANLIB)
       list(APPEND BZIP2_EXTRA_ARGS RANLIB=${CMAKE_RANLIB})
     endif()
   
   ```
   
   Instead of:
   https://github.com/apache/arrow/blob/bad8824d5cda0fd8337c7167729c49af868f93a5/cpp/cmake_modules/ThirdpartyToolchain.cmake#L636-L642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #11334: ARROW-14210: [C++] Add AR and RANLIB flags to bzip2

Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11334:
URL: https://github.com/apache/arrow/pull/11334#issuecomment-935163758


   It should work.
   
   Could you confirm this on your local environment?
   
   And cloud you update pull request description to be suitable for commit message? Our merge tool uses pull request description as commit message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #11334: ARROW-14210: [C++] Add AR and RANLIB flags to bzip2

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11334:
URL: https://github.com/apache/arrow/pull/11334#issuecomment-935152646






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] karldw commented on pull request #11334: ARROW-14210: [C++] Add AR and RANLIB flags to bzip2

Posted by GitBox <gi...@apache.org>.
karldw commented on pull request #11334:
URL: https://github.com/apache/arrow/pull/11334#issuecomment-935184631


   This does work in my local environment. For anyone who want to test (no need for you to do it), there are directions in the opening comment here: https://issues.apache.org/jira/browse/ARROW-14210


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou closed pull request #11334: ARROW-14210: [C++] Add AR and RANLIB flags to bzip2

Posted by GitBox <gi...@apache.org>.
kou closed pull request #11334:
URL: https://github.com/apache/arrow/pull/11334


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] karldw commented on pull request #11334: ARROW-14210: [C++] Add AR and RANLIB flags to bzip2

Posted by GitBox <gi...@apache.org>.
karldw commented on pull request #11334:
URL: https://github.com/apache/arrow/pull/11334#issuecomment-935183555


   Does the pull request description work now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org