[GitHub] [couchdb-ioq] chewbranca opened a new pull request #13: Allow for dynamic ioq classes

[GitBox <gi...@apache.org>]

chewbranca opened a new pull request #13: Allow for dynamic ioq classes
URL: https://github.com/apache/couchdb-ioq/pull/13
 
 
       Allow dynamic classes in is_valid_class
   
       This adds support for dynamic classes in IOQ2. Before this change, the
       allowed set of classes was fixed and hardcoded, with no way for 3rd
       party IO traffic to be prioritized, and similarly, no way for 3rd party
       IO traffic to bypass IOQ based on config settings. This change switches
       to checking to see if there's a declared IO priority value in the
       classes config, and if so it is treated as a valid value. It's worth
       noting that because `ioq_config:set_class_config` uses the
       `is_valid_class` check, you must use `config:set` directly to declare an
       initial priority for the dynamic channel before being able to use the
       `ioq_config` helpers.
       
       This change was motivated by not being able to bypass search in the
       Dreyfus project, as it piggy-backed off of `interactive` and
       `view_update` channels. That was rectified in [1], and now Dreyfus uses
       the `search` IOQ channel. As that is not used in CouchDB directly, this
       commit adds the dynamic class support based off of config values, rather
       than specifically hardcoding search, so that it can be used by any 3rd
       party services running IO traffic through IOQ.
       
       [1] https://github.com/cloudant-labs/dreyfus/pull/46/commits/75d86c49c86f4e7e299d2d05a741c4ef68a144fb
   
   
   TODO BEFORE MERGING:
     - [ ] update IOQ2.md with details on how to declare dynamic channels.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services