[jira] [Created] (GROOVY-7751) CallableStatement leak in Sql.call() method

["Alexey Vladykin (JIRA)" <ji...@apache.org>]

Alexey Vladykin created GROOVY-7751:
---------------------------------------

             Summary: CallableStatement leak in Sql.call() method
                 Key: GROOVY-7751
                 URL: https://issues.apache.org/jira/browse/GROOVY-7751
             Project: Groovy
          Issue Type: Bug
          Components: SQL processing
    Affects Versions: 2.4.5
            Reporter: Alexey Vladykin


All {{Sql.call(...)}} methods ultimately delegate to {{Sql.callWithRows(...)}} method where we have:
{code:java}
try {
    statement = connection.prepareCall(sql);
    // ...
} finally {
    // ...
    closeResources(connection, statement);
}
{code}

The problem is that statement is unconditionally parsed and compiled each time, but the {{closeResources()}} method only closes it when statement caching is disabled. So with statement caching enabled we end up allocating and leaking a new CallableStatement instance per {{Sql.call()}} invocation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)