You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/28 02:19:16 UTC

[GitHub] [rocketmq] tsunghanjacktsai commented on pull request #4518: [ISSUE #4463] fix broker is normal exit, but indexFile not flush disk

tsunghanjacktsai commented on PR #4518:
URL: https://github.com/apache/rocketmq/pull/4518#issuecomment-1168138696

   Hi @Kvicii ,
   
   We really appreciate your effort in helping us make RocketMQ stronger. However, I've seen many times that you approved the changes immediately without careful review (e.g. this PR didn't even pass the CI). We welcome you to join us and make a contribution, but this is definitely not the behavior we want in our community.
   
   If you'd like to learn details of RocketMQ or how to review our code, please leave me a message via email, where you could find it on my main profile.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org