You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/09 18:34:25 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4103: LTP: fix stacke overflow bug in case ltp_interfaces_pthread_attr_setstacksize_1_1

xiaoxiang781216 commented on a change in pull request #4103:
URL: https://github.com/apache/incubator-nuttx/pull/4103#discussion_r667141342



##########
File path: sched/Kconfig
##########
@@ -1819,7 +1819,7 @@ config IDLETHREAD_STACKSIZE
 
 config PTHREAD_STACK_MIN
 	int "Minimum pthread stack size"
-	default 256
+	default DEFAULT_TASK_STACKSIZE

Review comment:
       256B is normally too small to run a thread, can you any thread on Cortex M4 MCU with so small stack? especially if the interrupt stack is disabled. PTHREAD_STACK_MIN is seldom used macro, we found this issue in one LTP test case which run create a thread with PTHREAD_STACK_MIN(256B) stack and crash immediately.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org