[jira] [Commented] (KAFKA-1491) ConsumerMetadataResponse is not read completely

["Joel Koshy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028556#comment-14028556 ] 

Joel Koshy commented on KAFKA-1491:
-----------------------------------

So it turns out this is not as bad as I thought.

We read ConsumerMetadatResponse's through a request channel in ClientUtils.
The entire response is received and we just call readFrom on the underlying
buffer. It's fine if we ignore the remaining since retries create a new
BoundedByteBufferReceive.

I verified this locally.

That said, we may as well change the code to always read the coordinator.



> ConsumerMetadataResponse is not read completely
> -----------------------------------------------
>
>                 Key: KAFKA-1491
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1491
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Joel Koshy
>
> This is a regression after KAFKA-1437
> The broker always populates the coordinator broker field, but the consumer may do a partial read if error code is non-zero. It should always read the field or we will probably end up with a buffer overflow exception of some sort when reading from a response that has a non-zero error code.



--
This message was sent by Atlassian JIRA
(v6.2#6252)