You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by "coheigea (via GitHub)" <gi...@apache.org> on 2026/09/04 13:31:25 UTC
[PR] Put a max length on the Fiql search term and fix performance parsing … [cxf]
coheigea opened a new pull request, #3443:
URL: https://github.com/apache/cxf/pull/3443
…issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Put a max length on the Fiql search term and fix performance parsing … [cxf]
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #3443:
URL: https://github.com/apache/cxf/pull/3443#discussion_r3936460641
##########
rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/fiql/FiqlParser.java:
##########
@@ -305,6 +338,40 @@ protected ASTNode<T> parseComparison(String expr) throws SearchParseException {
throw new SearchParseException("Not a comparison expression: " + expr);
}
+ private int[] findComparator(String expr) {
Review Comment:
@coheigea I do understand the intent here, but does it actually make sense to go such far (basically rewriting what regex is doing)? We've limited the expression length, I think the issue should be largely mitigated, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Put a max length on the Fiql search term [cxf]
Posted by "coheigea (via GitHub)" <gi...@apache.org>.
coheigea commented on code in PR #3443:
URL: https://github.com/apache/cxf/pull/3443#discussion_r3948631820
##########
rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/fiql/FiqlParser.java:
##########
@@ -305,6 +338,40 @@ protected ASTNode<T> parseComparison(String expr) throws SearchParseException {
throw new SearchParseException("Not a comparison expression: " + expr);
}
+ private int[] findComparator(String expr) {
Review Comment:
@reta It's a fair point. I limited the search term even further to 4K characters by default and removed this custom code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Put a max length on the Fiql search term [cxf]
Posted by "coheigea (via GitHub)" <gi...@apache.org>.
coheigea merged PR #3443:
URL: https://github.com/apache/cxf/pull/3443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org