You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/31 03:12:43 UTC

[GitHub] [fineract] thesmallstar commented on a change in pull request #951: FINERACT-822 Enable Warnings CompareToZero

thesmallstar commented on a change in pull request #951:
URL: https://github.com/apache/fineract/pull/951#discussion_r432905225



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabDataValidator.java
##########
@@ -239,7 +239,7 @@ public void validateChartSlabsUpdate(final JsonElement element, final DataValida
         }
 
         if (amountRangeFrom != null && amountRangeTo != null) {
-            if (amountRangeFrom.compareTo(amountRangeTo) > 1) {
+            if (amountRangeFrom.compareTo(amountRangeTo) > 0) {

Review comment:
       Just curious of this change, @percyashu can you please tell why they mean the same thing?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org