You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by iamrakesh <gi...@git.apache.org> on 2015/12/24 15:49:47 UTC

[GitHub] wicket pull request: updated gather-browser-info implementation

GitHub user iamrakesh opened a pull request:

    https://github.com/apache/wicket/pull/152

    updated gather-browser-info implementation

    Current WebClientInfo and related classes to gather browser info are bit difficult to extend/customize.
    
    The changes in this PR will allow to extend this implementation and customize to use client side browser feature detection JavaScript libraries and pass it on to server.
    
    Initial discussion can be found at http://apache-wicket.1842946.n4.nabble.com/Regarding-Browser-Client-info-implementation-td4673024.html

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iamrakesh/wicket browserinfo_improvements

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #152
    
----
commit 351f084872467f0d3d0f339ab9c20afb4f79d2d1
Author: iamrakesh <ra...@hotmail.co.in>
Date:   2015-12-24T10:08:22Z

    updated gather-browser-info implementation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket issue #152: updated gather-browser-info implementation

Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:

    https://github.com/apache/wicket/pull/152
  
    @iamrakesh  Please close this PR. We don't have permissions to close it ourselves. Thanks!
    A solution has been provided with Wicket 6.26.0/7.6.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request #152: updated gather-browser-info implementation

Posted by iamrakesh <gi...@git.apache.org>.
Github user iamrakesh closed the pull request at:

    https://github.com/apache/wicket/pull/152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---