You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/02 16:44:59 UTC

[GitHub] [bookkeeper] lhotari opened a new issue #2408: [documentation] "The flat ledger manager is the default" is a false claim

lhotari opened a new issue #2408:
URL: https://github.com/apache/bookkeeper/issues/2408


   The documentation claims that "The flat ledger manager is the default". 
   https://github.com/apache/bookkeeper/blob/master/site/docs/latest/getting-started/concepts.md#use-the-flat-ledger-manager-in-most-cases
   
   However, the default is HierarchicalLedgerManagerFactory and this can be seen at
   https://github.com/apache/bookkeeper/blob/a0d49fcb65a40b2b49fbfb6c50f60c7a9f66f67f/bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManagerFactory.java#L316
   
   The documentation for configuration already mentions hierarchical as the default
   https://github.com/apache/bookkeeper/blob/94912a9fdca68391866baf598c36708e406728f8/site/_data/config/bk_server.yaml#L485-L495 
   
   However, It would be better to remove "The flat ledger manager is the default " from the sentence in concepts.md.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] WJL3333 commented on issue #2408: [documentation] "The flat ledger manager is the default" is a false claim

Posted by GitBox <gi...@apache.org>.
WJL3333 commented on issue #2408:
URL: https://github.com/apache/bookkeeper/issues/2408#issuecomment-691403219


   submit a pr here https://github.com/apache/bookkeeper/pull/2413


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli commented on issue #2408: [documentation] "The flat ledger manager is the default" is a false claim

Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2408:
URL: https://github.com/apache/bookkeeper/issues/2408#issuecomment-685881157


   You are right 
   It is also deprecated.
   
   Can you please send PR? The website is in this repository 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] WJL3333 commented on issue #2408: [documentation] "The flat ledger manager is the default" is a false claim

Posted by GitBox <gi...@apache.org>.
WJL3333 commented on issue #2408:
URL: https://github.com/apache/bookkeeper/issues/2408#issuecomment-691403219


   submit a pr here https://github.com/apache/bookkeeper/pull/2413


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] jiazhai closed issue #2408: [documentation] "The flat ledger manager is the default" is a false claim

Posted by GitBox <gi...@apache.org>.
jiazhai closed issue #2408:
URL: https://github.com/apache/bookkeeper/issues/2408


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] WJL3333 commented on issue #2408: [documentation] "The flat ledger manager is the default" is a false claim

Posted by GitBox <gi...@apache.org>.
WJL3333 commented on issue #2408:
URL: https://github.com/apache/bookkeeper/issues/2408#issuecomment-691403219






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] WJL3333 commented on issue #2408: [documentation] "The flat ledger manager is the default" is a false claim

Posted by GitBox <gi...@apache.org>.
WJL3333 commented on issue #2408:
URL: https://github.com/apache/bookkeeper/issues/2408#issuecomment-691403219






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org