[GitHub] [kafka] michael-carter-instaclustr commented on pull request #8844: KAFKA-9887 fix failed task or connector count on startup failure

[GitBox <gi...@apache.org>]

michael-carter-instaclustr commented on pull request #8844:
URL: https://github.com/apache/kafka/pull/8844#issuecomment-811661662


   Thanks for having a look at this @rhauch . I've updated with the suggested log messages, and reordered the methods and lines in the ConnectorStatusListener. I've also put back in most of the assertStartupStatistics. There were a couple that I couldn't leave in there without breaking the unit test. I believe this is because the recording of the statistic is now deferred to a piece of code submitted to the execution service, rather than something that is set directly by the startTask method. The only thing I could think of to keep them in there was to fake an executor service that would call things as soon as they were submitted, but since that isn't how it would work in reality, it didn't seem like the right thing to do. Neither did keeping them in there and just asserting that they were 0 the whole time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org