[GitHub] [incubator-superset] rusackas commented on a change in pull request #11241: refactor: Replace usages of reactable in ChangeDatasourceModal

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11241:
URL: https://github.com/apache/incubator-superset/pull/11241#discussion_r505716343



##########
File path: superset-frontend/src/datasource/ChangeDatasourceModal.tsx
##########
@@ -120,6 +119,21 @@ const ChangeDatasourceModal: FunctionComponent<ChangeDatasourceModalProps> = ({
     setFilter((event.currentTarget?.value as string) ?? '');
   };
 
+  const columns = useMemo(

Review comment:
       It doesn't seem like this `TABLE_COLUMNS` is used anywhere else... should we just define a `const` using this `map` up between lines 36-37, and refer to the `const` here, rather than using `useMemo` at all?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org