You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/21 13:09:26 UTC
[GitHub] [cordova-cli] breautek opened a new issue #526: cordova diagnostic command
breautek opened a new issue #526:
URL: https://github.com/apache/cordova-cli/issues/526
# Feature Request
## Motivation Behind Feature
<!-- Why should this feature be implemented? What problem does it solve? -->
A single command that collects most the information (and maybe more) that our github issue template asks.
## Feature Description
<!--
Describe your feature request in detail
Please provide any code examples or screenshots of what this feature would look like
Are there any drawbacks? Will this break anything for existing users?
-->
The collected information should include:
- OS platform & Version
- XCode version (if on mac)
- Android Studio version & installed android sdks
- Installed java version
- NodeJS & NPM version
- Cordova version
- Installed cordova platforms & their versions
- Installed cordova plugins & their versions
- The NPM dependency tree via `npm ls` (see https://github.com/apache/cordova-android/issues/1027#issuecomment-677762390)
- Any other environment information that might be relevant for each platform. This isn't necessary a complete list.
Obviously this won't cover everything that is requested in our issue template, such as:
- The problem they are experiencing
- The actual result they are expected
- What mobile devices they are using
But we'll still would then be able to request/tell the user to run `cordova diagnostic` which will print out or perhaps write to a file. Of course not everyone will bother, but this command will be far more easier than telling the user to run variety of different commands to get this information that we request.
## Alternatives or Workarounds
<!--
Describe alternatives or workarounds you are currently using
Are there ways to do this with existing functionality?
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] breautek commented on issue #526: cordova diagnostic command
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #526:
URL: https://github.com/apache/cordova-cli/issues/526#issuecomment-683805909
> I think it's debatable if the Java version is actually needed. After all we just re-assured ourselves that nothing except Java 8 will work anyway sweat_smile.
Yeah, but I mean, if it helps us pinpoint an environment flaw, I think it's still good to include.
> Regarding the node modules dependency tree: running npm ls takes very long usually, so I would prefer to avoid running it as part of cordova info. If needed, users can easily provide that information separately.
Perhaps. I just learned about the `npm ls` command myself. Just have to I guess tell people to either try clearing their `package-lock.json` / `node_modules` tree and reinstalling to ensure all their dependencies are up to date, especially when they have weird issues that aren't reproducible.
> Since cordova-android is the only part of Cordova that uses Java, Java version information should be provided by cordova-android's upcoming API method getEnvironmentInfo.
Agreed. And I think our consensus is the only thing that should be added is Java, so perhaps this issue should be closed and a new issue should be created in `cordova-android`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] raphinesse commented on issue #526: cordova diagnostic command
Posted by GitBox <gi...@apache.org>.
raphinesse commented on issue #526:
URL: https://github.com/apache/cordova-cli/issues/526#issuecomment-683631470
I think it's debatable if the Java version is actually needed. After all we just re-assured ourselves that nothing except Java 8 will work anyway :sweat_smile:. It still would be nice to have of course. The recent refactoring in #510 prepared the platform info API, where platform specific environment information should be collected by the platform and provided to CLI in a generic structured format. Since cordova-android is the only part of Cordova that uses Java, Java version information should be provided by cordova-android's upcoming info API.
Regarding the node modules dependency tree: running `npm ls` takes very long usually, so I would prefer to avoid running it as part of `cordova info`. If needed, users can easily provide that information separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] raphinesse commented on issue #526: cordova diagnostic command
Posted by GitBox <gi...@apache.org>.
raphinesse commented on issue #526:
URL: https://github.com/apache/cordova-cli/issues/526#issuecomment-683824204
> Agreed. And I think our consensus is the only thing that should be added is Java, so perhaps this issue should be closed and a new issue should be created in `cordova-android`?
If it's OK with you to drop the `npm ls` requirement then that would probably be the best course of action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] breautek commented on issue #526: cordova diagnostic command
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #526:
URL: https://github.com/apache/cordova-cli/issues/526#issuecomment-678702592
> What does `cordova info` lack to satisfy these requirements?
Definitely missed that command in `cordova help`, but I see it now. Let's see `cordova info` contains...
- :heavy_check_mark: OS Platform & Version
- Xcode version (not sure if it is included, but I assume it is, don't have a mac to test)
- :heavy_check_mark: installed android SDK versions. No Android Studio version, but I'll admit this doesn't really matter for most people.
- :x: Java version
- :heavy_check_mark: Node & NPM version
- :heavy_check_mark: cordova version (including cli, common, create, and lib/fetch/serve)
- :heavy_check_mark: Installed cordova platforms and their versions
- :x: node module dependency tree
So `cordova info` contains most of the information. So I guess the java version should be added to `cordova info` command.
I think "node modules dependency tree" can still be up to debate, but I think it may help identify issues caused by mismatch of sub dependencies, which appears to be the case on https://github.com/apache/cordova-android/issues/1027#issuecomment-677762390. However the `npm ls` command is rather verbose and may make it difficult for user to copy and paste. They can always use the redirect operator though to direct `stdout` to a file... via `cordova info > info.log`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] raphinesse commented on issue #526: cordova diagnostic command
Posted by GitBox <gi...@apache.org>.
raphinesse commented on issue #526:
URL: https://github.com/apache/cordova-cli/issues/526#issuecomment-678612727
What does `cordova info` lack to satisfy these requirements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] raphinesse edited a comment on issue #526: cordova diagnostic command
Posted by GitBox <gi...@apache.org>.
raphinesse edited a comment on issue #526:
URL: https://github.com/apache/cordova-cli/issues/526#issuecomment-683631470
I think it's debatable if the Java version is actually needed. After all we just re-assured ourselves that nothing except Java 8 will work anyway :sweat_smile:. It still would be nice to have of course. The recent refactoring in #510 prepared the platform info API, where platform specific environment information should be collected by the platform and provided to CLI in a generic structured format. Since cordova-android is the only part of Cordova that uses Java, Java version information should be provided by cordova-android's upcoming API method `getEnvironmentInfo`.
Regarding the node modules dependency tree: running `npm ls` takes very long usually, so I would prefer to avoid running it as part of `cordova info`. If needed, users can easily provide that information separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-cli] breautek closed issue #526: cordova diagnostic command
Posted by GitBox <gi...@apache.org>.
breautek closed issue #526:
URL: https://github.com/apache/cordova-cli/issues/526
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org