[GitHub] [pulsar] eolivelli commented on a change in pull request #10708: On multi-topic consumer, we shouldn't keep checking the partitioned metadata

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #10708:
URL: https://github.com/apache/pulsar/pull/10708#discussion_r639411467



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java
##########
@@ -955,7 +955,7 @@ private void doSubscribeTopicPartitions(Schema<T> schema,
                     })
                 .collect(Collectors.toList());
         } else {
-            boolean isTopicBeingSubscribedForInOtherThread = this.topics.putIfAbsent(topicName, 1) != null;
+            boolean isTopicBeingSubscribedForInOtherThread = this.topics.putIfAbsent(topicName, 0) != null;

Review comment:
       Does it make sense to create a constant for this magic value?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org