[jira] [Resolved] (NET-534) Unnecesssary call to getReplyString() if no listeners configured

["Sebb (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NET-534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-534.
----------------------

       Resolution: Fixed
    Fix Version/s: 3.4

URL: http://svn.apache.org/r1586170
Log:
NET-534 Unnecesssary call to getReplyString() if no listeners configured

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAP.java


> Unnecesssary call to getReplyString() if no listeners configured
> ----------------------------------------------------------------
>
>                 Key: NET-534
>                 URL: https://issues.apache.org/jira/browse/NET-534
>             Project: Commons Net
>          Issue Type: Improvement
>          Components: IMAP
>    Affects Versions: 3.3
>            Reporter: Sebb
>            Assignee: Sebb
>            Priority: Minor
>             Fix For: 3.4
>
>
> IMAP methods can return large amounts of data.
> The IMap.__getReply() method collects all the reply lines in a list which is converted to a string before being passed to SocketClient#fireReplyReceived(int, String). 
> If there are no listeners, the string conversion is unnecessary, and could be very expensive.
> The fireReplyReceived method could be overridden to avoid this.



--
This message was sent by Atlassian JIRA
(v6.2#6252)