You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2025/01/16 20:52:59 UTC
[PR] KAFKA-17561: add processId tag to thread-state metric [kafka]
mjsax opened a new pull request, #18581:
URL: https://github.com/apache/kafka/pull/18581
\cc @dajac -- this is a tiny follow up PR for KIP-1091: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1091%3A+Improved+Kafka+Streams+operator+metrics
We want to add one more tag `processId` to the newly added `thread-state` metric. I hope there is no objection to merge this for 4.0 release. If you don't have any objection, I will also update the KIP and send an email to the KIP voting thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17561: add processId tag to thread-state metric [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #18581:
URL: https://github.com/apache/kafka/pull/18581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17561: add processId tag to thread-state metric [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on PR #18581:
URL: https://github.com/apache/kafka/pull/18581#issuecomment-2605087438
I think we need to add the `processId` to the `StreamsMetricsImpl#addThreadLevelImmutableMetric` as well
Otherwise this LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17561: add processId tag to thread-state metric [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on PR #18581:
URL: https://github.com/apache/kafka/pull/18581#issuecomment-2597605302
sounds good to me. thanks for letting me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org