[I] 11.x: Rename some enabled configs to mode [trafficserver]

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt opened a new issue, #12412:
URL: https://github.com/apache/trafficserver/issues/12412

   Per the discussion here:
   https://github.com/apache/trafficserver/pull/11902
   
   It would be clearer for end users if the configs that are named `enabled` were booleans. Currently that is the case for many of them, but the following take an enumeration of values that control behavior:
   
   ```
   proxy.config.output.logfile.rolling_enabled
   proxy.config.mlock_enabled
   proxy.config.http.response_server_enabled
   proxy.config.log.logging_enabled
   proxy.config.log.rolling_enabled
   proxy.config.diags.debug.enabled
   proxy.config.diags.logfile.rolling_enabled
   proxy.config.ssl.session_cache.enabled
   ```
   
   Each of these would be better off being renamed to `.mode` configs.
   
   I briefly attempted to add support for both the `.mode` versions as well as the `enabled` versions (see #12409), but this becomes very tricky. What if both are in the config and have different values? Emit an emergency, I thought, because how can ATS decide between them? OK, but be sure to handle the case where one is the implicit default. Oh, and be sure to handle plugin overrides. And be careful with those that are overridable configs. Etc. In the end I thought the rules for supporting both would be more confusing for the user and hard to not implement without bugs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] 11.x: Rename some enabled configs to mode [trafficserver]

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on issue #12412:
URL: https://github.com/apache/trafficserver/issues/12412#issuecomment-3145121803

   To avoid conflicts, I suggest delaying doing this until we are closer to release. The patch is pretty straightforward to just rename them, but will make patches not align when we do. (Don't forget to update our variable names when the configs are updated.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org