[GitHub] [maven-resolver] cstamas commented on a diff in pull request #315: [MRESOLVER-382] allow setting outgoing interface

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on code in PR #315:
URL: https://github.com/apache/maven-resolver/pull/315#discussion_r1267875400


##########
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##########
@@ -295,6 +300,19 @@ final class HttpTransporter extends AbstractTransporter {
         this.client = builder.build();
     }
 
+    private InetAddress getBindAddress(RepositorySystemSession session) {
+        String bindAddress = ConfigUtils.getString(session, null, BIND_ADDRESS);

Review Comment:
   I can envision some show that may be "segmented" (network wise). Hence, this seems to me low hanging fruit to all o"route per remote repository", so why not?



##########
maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java:
##########
@@ -295,6 +300,19 @@ final class HttpTransporter extends AbstractTransporter {
         this.client = builder.build();
     }
 
+    private InetAddress getBindAddress(RepositorySystemSession session) {
+        String bindAddress = ConfigUtils.getString(session, null, BIND_ADDRESS);

Review Comment:
   I can envision some shop that may be "segmented" (network wise). Hence, this seems to me low hanging fruit to all o"route per remote repository", so why not?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org