You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "keon94 (via GitHub)" <gi...@apache.org> on 2023/06/13 05:52:54 UTC
[GitHub] [incubator-devlake] keon94 opened a new pull request, #5454: fix(pydevlake): make-pipeline must account for _raw_data_params
keon94 opened a new pull request, #5454:
URL: https://github.com/apache/incubator-devlake/pull/5454
### Summary
What does this PR do?
make-pipeline in Python does not set _raw_data_params which leads to this:
empty column.
### Does this close any open issues?
Closes n/a
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] CamilleTeruel commented on a diff in pull request #5454: fix(pydevlake): make-pipeline must account for _raw_data_params
Posted by "CamilleTeruel (via GitHub)" <gi...@apache.org>.
CamilleTeruel commented on code in PR #5454:
URL: https://github.com/apache/incubator-devlake/pull/5454#discussion_r1227676730
##########
backend/python/pydevlake/pydevlake/plugin.py:
##########
@@ -139,6 +139,7 @@ def make_pipeline(self, scope_config_pairs: list[ScopeConfigPair],
for tool_scope, _ in scope_config_pairs:
for scope in self.domain_scopes(tool_scope):
scope.id = tool_scope.domain_id()
+ scope.raw_data_params = _raw_data_params(connection.id, scope.id)
Review Comment:
`raw_data_params` is the name of the python attribute, but the column is named `_raw_data_params` (see `model.py::RawDataOrigin). We have to use this alias because SQLModel doesn't create columns for attribute starting with a _
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 merged pull request #5454: fix(pydevlake): make-pipeline must account for _raw_data_params
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 merged PR #5454:
URL: https://github.com/apache/incubator-devlake/pull/5454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #5454: fix(pydevlake): make-pipeline must account for _raw_data_params
Posted by "keon94 (via GitHub)" <gi...@apache.org>.
keon94 commented on code in PR #5454:
URL: https://github.com/apache/incubator-devlake/pull/5454#discussion_r1227566345
##########
backend/python/pydevlake/pydevlake/plugin.py:
##########
@@ -139,6 +139,7 @@ def make_pipeline(self, scope_config_pairs: list[ScopeConfigPair],
for tool_scope, _ in scope_config_pairs:
for scope in self.domain_scopes(tool_scope):
scope.id = tool_scope.domain_id()
+ scope.raw_data_params = _raw_data_params(connection.id, scope.id)
Review Comment:
Golang expects _raw_data_params instead of raw_data_params
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] CamilleTeruel commented on a diff in pull request #5454: fix(pydevlake): make-pipeline must account for _raw_data_params
Posted by "CamilleTeruel (via GitHub)" <gi...@apache.org>.
CamilleTeruel commented on code in PR #5454:
URL: https://github.com/apache/incubator-devlake/pull/5454#discussion_r1227676730
##########
backend/python/pydevlake/pydevlake/plugin.py:
##########
@@ -139,6 +139,7 @@ def make_pipeline(self, scope_config_pairs: list[ScopeConfigPair],
for tool_scope, _ in scope_config_pairs:
for scope in self.domain_scopes(tool_scope):
scope.id = tool_scope.domain_id()
+ scope.raw_data_params = _raw_data_params(connection.id, scope.id)
Review Comment:
`raw_data_params` is the name of the python attribute, but the column is named `_raw_data_params` (see `model.py::RawDataOrigin). We have to use this alias because SQLModel doesn't create columns for attribute starting with `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] CamilleTeruel commented on a diff in pull request #5454: fix(pydevlake): make-pipeline must account for _raw_data_params
Posted by "CamilleTeruel (via GitHub)" <gi...@apache.org>.
CamilleTeruel commented on code in PR #5454:
URL: https://github.com/apache/incubator-devlake/pull/5454#discussion_r1227676730
##########
backend/python/pydevlake/pydevlake/plugin.py:
##########
@@ -139,6 +139,7 @@ def make_pipeline(self, scope_config_pairs: list[ScopeConfigPair],
for tool_scope, _ in scope_config_pairs:
for scope in self.domain_scopes(tool_scope):
scope.id = tool_scope.domain_id()
+ scope.raw_data_params = _raw_data_params(connection.id, scope.id)
Review Comment:
`raw_data_params` is the name of the python attribute, but the column is named `_raw_data_params` (see `model.py::RawDataOrigin)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org