You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/09 13:20:52 UTC

[GitHub] [echarts] plainheart commented on a change in pull request #14417: Fix(sankey): sankey label has higher z2

plainheart commented on a change in pull request #14417:
URL: https://github.com/apache/echarts/pull/14417#discussion_r610620369



##########
File path: src/chart/sankey/SankeyView.ts
##########
@@ -250,7 +250,8 @@ class SankeyView extends ChartView {
                     width: layout.dx,
                     height: layout.dy
                 },
-                style: itemModel.getModel('itemStyle').getItemStyle()
+                style: itemModel.getModel('itemStyle').getItemStyle(),
+                z2: 10

Review comment:
       @pissang @susiwen8  Sorry here. I ever reverted it in #14542. But for now, this change seems to be still needed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org