[GitHub] [servicecomb-java-chassis] yhs0092 commented on a change in pull request #1340: [SCB-1511]when use method override, the generated swagger body is wrong

[GitBox <gi...@apache.org>]

yhs0092 commented on a change in pull request #1340: [SCB-1511]when use method override, the generated swagger body is wrong
URL: https://github.com/apache/servicecomb-java-chassis/pull/1340#discussion_r332853776
 
 

 ##########
 File path: swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/generator/core/utils/ClassUtils.java
 ##########
 @@ -49,10 +49,10 @@ private ClassUtils() {
 
   // 将一系列body parameter包装成一个class
   public static Class<?> getOrCreateBodyClass(OperationGenerator operationGenerator,
-      List<BodyParameter> bodyParameters) {
+      List<BodyParameter> bodyParameters, String bodyParamName) {
     SwaggerGenerator swaggerGenerator = operationGenerator.getSwaggerGenerator();
     Method method = operationGenerator.getProviderMethod();
 
 Review comment:
   The variable `method` seems not used. Maybe we can remove the parameter `bodyParamName` and generate it by invoking `ParamUtils.generateBodyParameterName(method)` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services