[jira] [Commented] (CAMEL-12358) Camel-SMPP: Use timeout when creating socket connection

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402319#comment-16402319 ] 

ASF GitHub Bot commented on CAMEL-12358:
----------------------------------------

PascalSchumacher opened a new pull request #2258: CAMEL-12358: Camel-SMPP: Use timeout when creating socket connection
URL: https://github.com/apache/camel/pull/2258
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Camel-SMPP: Use timeout when creating socket connection
> -------------------------------------------------------
>
>                 Key: CAMEL-12358
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12358
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-smpp
>            Reporter: Pascal Schumacher
>            Assignee: Pascal Schumacher
>            Priority: Major
>
> Camel-SMPP is using
> _javax.net.SocketFactory#createSocket(String host, int port)_ which "creates a socket and connects it to the specified port number at the specified address" according to the javadoc.
> As _SocketFactory_ is an abstract class, the behavior of _createSocket(String host, int port)_depends on the concrete implementation in use, but at least the default implementation of Oracle Java 8 Update 152 connects without using a timeout.
> As blocking operations without timeouts should be avoided Camel-SMPP should use a timeout when connecting the socket.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)