[GitHub] [solr] risdenk commented on pull request #1443: SOLR-16676: Test improvements

["risdenk (via GitHub)" <gi...@apache.org>]

risdenk commented on PR #1443:
URL: https://github.com/apache/solr/pull/1443#issuecomment-1460596179

   > sorry, there are a lot of cosmetic changes here. while I don't disagree with these, they are 'nice to have' rather than adding some meaningful change to understand why this might be failing. if you don't mind, could you focus on failure-fixing patches first to get the builds passing reliably, and then we can make the code clean(er) and nice(er).
   
   I'm with you I just put this together to try to see if there were missing assertions and general cleanup. I agree it would be better to fix the underlying issue first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org