You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/03/11 18:11:47 UTC

Review Request 44713: Ambari names jar 'ojdbc6.jar' even though it is actually ojdbc7.jar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44713/
-----------------------------------------------------------

Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-15390
    https://issues.apache.org/jira/browse/AMBARI-15390


Repository: ambari


Description
-------

PROBLEM:
When set up jdbc driver with 
ambari-server setup --jdbc-db=oracle --jdbc-driver=/tmp/ojdbc7.jar
and see that it is properly set up in /var/lib/ambari-server/resources, and also cleaned up any ojdbc*.jar in the cluster, when restart HDFS service, Ambari copies the jar but name it 'ojdbc6.jar'


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 23571c6 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 352be9f 
  ambari-server/src/main/python/ambari_server/serverSetup.py 7f6a7e3 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py c5d45ee 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 9084c87 
  ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 7cbcb1e 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py 6218fe0 
  ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py 392bff7 
  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 83a3287 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py 32e1393 
  ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 1f44967 
  ambari-server/src/test/python/stacks/2.0.6/SQOOP/test_sqoop.py 040dacb 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json fa1ef22 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json b2543c8 
  ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 9d61915 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json c772a0e 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 80e4e36 
  ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 92c09c3 

Diff: https://reviews.apache.org/r/44713/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 44713: Ambari names jar 'ojdbc6.jar' even though it is actually ojdbc7.jar

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44713/#review123403
-----------------------------------------------------------


Ship it!




Ship It!

- Dmytro Sen


On Март 11, 2016, 5:11 п.п., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44713/
> -----------------------------------------------------------
> 
> (Updated Март 11, 2016, 5:11 п.п.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15390
>     https://issues.apache.org/jira/browse/AMBARI-15390
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM:
> When set up jdbc driver with 
> ambari-server setup --jdbc-db=oracle --jdbc-driver=/tmp/ojdbc7.jar
> and see that it is properly set up in /var/lib/ambari-server/resources, and also cleaned up any ojdbc*.jar in the cluster, when restart HDFS service, Ambari copies the jar but name it 'ojdbc6.jar'
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java 23571c6 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java 352be9f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 7f6a7e3 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py c5d45ee 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py 9084c87 
>   ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 7cbcb1e 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py 6218fe0 
>   ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py 392bff7 
>   ambari-server/src/main/resources/custom_actions/scripts/check_host.py 83a3287 
>   ambari-server/src/test/python/custom_actions/TestCheckHost.py 32e1393 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 1f44967 
>   ambari-server/src/test/python/stacks/2.0.6/SQOOP/test_sqoop.py 040dacb 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json fa1ef22 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default_oozie_mysql.json b2543c8 
>   ambari-server/src/test/python/stacks/2.0.6/configs/oozie_existing_sqla.json 9d61915 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json c772a0e 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 80e4e36 
>   ambari-server/src/test/python/stacks/2.2/configs/oozie-upgrade.json 92c09c3 
> 
> Diff: https://reviews.apache.org/r/44713/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>