You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/07/27 08:55:25 UTC
[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #759: Propagate sanitizer flags to all cmake deps
PragmaTwice opened a new pull request, #759:
URL: https://github.com/apache/incubator-kvrocks/pull/759
- solve #639
- apply sanitizer flags to all cmake deps to avoid false positive report
- ban sanitizer build while jemalloc is enabled
- add [tsan-suppressions](https://github.com/apache/incubator-kvrocks/compare/unstable...PragmaTwice:fix-san-build?expand=1#diff-a16454a82fd4f3403a2e89418377f5f34f7f566fba4456bdc9005667c6c4fcc1) to suppress specific TSan reports
- enable TSan builds in the workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #759: Propagate sanitizer flags to all cmake deps
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #759:
URL: https://github.com/apache/incubator-kvrocks/pull/759#issuecomment-1200238021
Hello everyone, any thought on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #759: Propagate sanitizer flags to all cmake deps
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on code in PR #759:
URL: https://github.com/apache/incubator-kvrocks/pull/759#discussion_r930959622
##########
.github/workflows/kvrocks.yaml:
##########
@@ -158,10 +156,13 @@ jobs:
run: ./x.py build -j$NPROC --unittest --compiler ${{ matrix.compiler }} ${{ matrix.with_ninja }} ${{ matrix.with_sanitizer }} ${{ matrix.without_jemalloc }} ${{ matrix.without_luajit }}
- name: Run Unit Test
- run: ./build/unittest
+ run: |
+ export ${{ matrix.runtime_env_vars }}
+ ./build/unittest
- name: Run Redis Tcl Test
run: |
+ export ${{ matrix.runtime_env_vars }}
Review Comment:
I think it is hard to eval something in `env` like `$(realpath ./tests/tsan-suppressions)`, do you have any suggestions?
##########
.github/workflows/kvrocks.yaml:
##########
@@ -158,10 +156,13 @@ jobs:
run: ./x.py build -j$NPROC --unittest --compiler ${{ matrix.compiler }} ${{ matrix.with_ninja }} ${{ matrix.with_sanitizer }} ${{ matrix.without_jemalloc }} ${{ matrix.without_luajit }}
- name: Run Unit Test
- run: ./build/unittest
+ run: |
+ export ${{ matrix.runtime_env_vars }}
+ ./build/unittest
- name: Run Redis Tcl Test
run: |
+ export ${{ matrix.runtime_env_vars }}
Review Comment:
I think it is hard to eval something in `env` like `$(realpath ./tests/tsan-suppressions)`, do you have any suggestion here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice merged pull request #759: Propagate sanitizer flags to all cmake deps
Posted by GitBox <gi...@apache.org>.
PragmaTwice merged PR #759:
URL: https://github.com/apache/incubator-kvrocks/pull/759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #759: Propagate sanitizer flags to all cmake deps
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #759:
URL: https://github.com/apache/incubator-kvrocks/pull/759#discussion_r930844605
##########
.github/workflows/kvrocks.yaml:
##########
@@ -158,10 +156,13 @@ jobs:
run: ./x.py build -j$NPROC --unittest --compiler ${{ matrix.compiler }} ${{ matrix.with_ninja }} ${{ matrix.with_sanitizer }} ${{ matrix.without_jemalloc }} ${{ matrix.without_luajit }}
- name: Run Unit Test
- run: ./build/unittest
+ run: |
+ export ${{ matrix.runtime_env_vars }}
+ ./build/unittest
- name: Run Redis Tcl Test
run: |
+ export ${{ matrix.runtime_env_vars }}
Review Comment:
You can use `env` field of a step.
See also https://docs.github.com/en/actions/learn-github-actions/environment-variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #759: Propagate sanitizer flags to all cmake deps
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #759:
URL: https://github.com/apache/incubator-kvrocks/pull/759#discussion_r933851698
##########
.github/workflows/kvrocks.yaml:
##########
@@ -158,10 +156,13 @@ jobs:
run: ./x.py build -j$NPROC --unittest --compiler ${{ matrix.compiler }} ${{ matrix.with_ninja }} ${{ matrix.with_sanitizer }} ${{ matrix.without_jemalloc }} ${{ matrix.without_luajit }}
- name: Run Unit Test
- run: ./build/unittest
+ run: |
+ export ${{ matrix.runtime_env_vars }}
+ ./build/unittest
- name: Run Redis Tcl Test
run: |
+ export ${{ matrix.runtime_env_vars }}
Review Comment:
Aha. I get your point. Then let's keep this logic as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #759: Propagate sanitizer flags to all cmake deps
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #759:
URL: https://github.com/apache/incubator-kvrocks/pull/759#issuecomment-1200365303
Thanks all! Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #759: Propagate sanitizer flags to all cmake deps
Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #759:
URL: https://github.com/apache/incubator-kvrocks/pull/759#issuecomment-1196489925
```
*** [err]: requests on cluster are ok in tests/integration/cluster.tcl
Expected '16383' to be equal to '' (context: type source line 257 file /Users/runner/work/incubator-kvrocks/incubator-kvrocks/tests/tcl/tests/integration/cluster.tcl cmd {assert_equal "16383" [$r3 get $slot_16383_key]} proc ::test)
```
from https://github.com/apache/incubator-kvrocks/runs/7536793002?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org