You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2022/07/14 21:09:48 UTC

[GitHub] [samza] kw2542 commented on pull request #1617: SAMZA-2753: Consolidate Clocks

kw2542 commented on PR #1617:
URL: https://github.com/apache/samza/pull/1617#issuecomment-1184899123

   > Why are we making `SystemHighResolutionClock` singleton? It is unclear what the motivation is from the RB description nor the code.
   
   Two rationales behind:
   1. To be consistent with SystemClock 
   2. The implementation of returning `System.nanoTime` has nothing to do with instance of `SystemHighResolutionClock`, therefore a singleton pattern is more straightforward.
   What do you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org