[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4774: Refactor virtualColumn to extraColumn

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4774: Refactor virtualColumn to extraColumn
URL: https://github.com/apache/incubator-pinot/pull/4774#discussion_r342351015
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/segment/extracolumn/ExtraColumnContext.java
 ##########
 @@ -16,14 +16,28 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.pinot.core.segment.virtualcolumn;
+package org.apache.pinot.core.segment.extracolumn;
+
+import org.apache.pinot.common.data.FieldSpec;
+
 
 /**
- * Virtual column provider that contains the current segment name.
+ * Context used to pass arguments to the extra column provider.
  */
-public class SegmentNameVirtualColumnProvider extends SingleStringVirtualColumnProvider {
-  @Override
-  protected String getValue(VirtualColumnContext context) {
-    return context.getSegmentName();
+public class ExtraColumnContext {
 
 Review comment:
   SegmentNameVirtualColumnProvider got renamed to ExtraColumnContext?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org