[GitHub] lburgazzoli commented on a change in pull request #223: DO NOT MERGE - new builder poc

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #223: DO NOT MERGE - new builder poc
URL: https://github.com/apache/camel-k/pull/223#discussion_r233953360
 
 

 ##########
 File path: pkg/builder/builder.go
 ##########
 @@ -0,0 +1,201 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one or more
+contributor license agreements.  See the NOTICE file distributed with
+this work for additional information regarding copyright ownership.
+The ASF licenses this file to You under the Apache License, Version 2.0
+(the "License"); you may not use this file except in compliance with
+the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package builder
+
+import (
+	"context"
+	"errors"
+	"io/ioutil"
+	"os"
+	"sort"
+	"sync"
+	"sync/atomic"
+	"time"
+
+	"github.com/apache/camel-k/pkg/apis/camel/v1alpha1"
+
+	"github.com/sirupsen/logrus"
+)
+
+// ********************************
+//
+// Default builder
+//
+// ********************************
+
+type defaultBuilder struct {
+	log       *logrus.Entry
+	ctx       context.Context
+	requests  chan Request
+	interrupt chan bool
+	request   sync.Map
+	running   int32
+	namespace string
+}
+
+// New --
+func New(ctx context.Context, namespace string) Builder {
+	m := defaultBuilder{
+		log:       logrus.WithField("logger", "builder"),
+		ctx:       ctx,
+		requests:  make(chan Request),
+		interrupt: make(chan bool, 1),
+		running:   0,
+		namespace: namespace,
+	}
+
+	return &m
+}
+
+// Submit --
+func (b *defaultBuilder) Submit(request Request) Result {
+	if atomic.CompareAndSwapInt32(&b.running, 0, 1) {
+		go b.loop()
+	}
+
+	result, present := b.request.Load(request.Identifier)
+	if !present || result == nil {
+		result = Result{
+			Request: request,
+			Status:  StatusSubmitted,
+		}
+
+		b.log.Infof("submitting request: %+v", request)
+
+		b.request.Store(request.Identifier, result)
+		b.requests <- request
+	}
+
+	return result.(Result)
+}
+
+// Purge --
+func (b *defaultBuilder) Purge(request Request) {
+	b.request.Delete(request.Identifier)
+}
+
+// ********************************
+//
+// Helpers
+//
+// ********************************
+
+func (b *defaultBuilder) loop() {
+	for atomic.LoadInt32(&b.running) == 1 {
+		select {
+		case <-b.ctx.Done():
+			b.interrupt <- true
+
+			close(b.interrupt)
+			close(b.requests)
+
+			atomic.StoreInt32(&b.running, 0)
+		case r, ok := <-b.requests:
+			if ok {
+				b.log.Infof("executing request: %+v", r)
+				b.submit(r)
+			}
+		}
+	}
+}
+
+func (b *defaultBuilder) submit(request Request) {
+	result, present := b.request.Load(request.Identifier)
+	if !present || result == nil {
+		b.log.Panicf("no info found for: %+v", request.Identifier)
+	}
+
+	// update the status
+	r := result.(Result)
+	r.Status = StatusStarted
+	r.ProcessStartedAt = time.Now()
+
+	// create tmp path
+	tmp, err := ioutil.TempDir(os.TempDir(), "builder-")
+	if err != nil {
+		r.Status = StatusError
+		r.Error = err
+	}
+
+	os.RemoveAll(tmp)
+
+	// update the cache
+	b.request.Store(request.Identifier, r)
+
+	c := Context{
+		C:         b.ctx,
+		Values:    make(map[string]interface{}),
+		Path:      tmp,
+		Libraries: make([]v1alpha1.Artifact, 0),
+		StepsDone: make([]string, 0),
+		Namespace: b.namespace,
+		Request:   request,
+	}
+
+	// Sort steps by phase
+	sort.SliceStable(request.Steps, func(i, j int) bool {
+		return request.Steps[i].Phase() < request.Steps[j].Phase()
+	})
+
+	for _, step := range request.Steps {
 
 Review comment:
   Yes a full build is needed now, it is much simpler and it avoid clashes as you said. About parallel build, yeah, I'm not sure they are needed, so let's keep it simple for the moment.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services