You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/20 07:29:51 UTC

[GitHub] [dolphinscheduler] EricGao888 commented on pull request #12062: [Improve] Improve support test tasks UT

EricGao888 commented on PR #12062:
URL: https://github.com/apache/dolphinscheduler/pull/12062#issuecomment-1251952599

   Actually, CI may not run some cases in this test class because there are both jUnit4 and jUnit5 style cases. And this kind of problem also exists in other 33 files. It looks like although we haven't add explicit dependency of jUnit5 yet, both versions of test cases have existed in DS project for a long time. Maybe we have some transitive dependencies on jUnit5 in this project.
   
   But this is out of the scope of this PR. I will handle them when doing DSIP-10 #10573
   
   cc @SbloodyS @caishunfeng @ruanwenjun 
   
   ![image](https://user-images.githubusercontent.com/34905992/191193636-e60b50bd-3096-4ca6-88a6-58fbab6e28b9.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org