You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/10/21 00:57:45 UTC

[kudu-CR] [server] cleanup on setting JWT verifier for messenger

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20608


Change subject: [server] cleanup on setting JWT verifier for messenger
......................................................................

[server] cleanup on setting JWT verifier for messenger

This patch doesn't contain any functional modifications.

Change-Id: I1c856135acad3eb13413f436adc9392923d42be8
---
M src/kudu/server/server_base.cc
1 file changed, 15 insertions(+), 20 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/20608/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c856135acad3eb13413f436adc9392923d42be8
Gerrit-Change-Number: 20608
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [server] cleanup on setting JWT verifier for messenger

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20608 )

Change subject: [server] cleanup on setting JWT verifier for messenger
......................................................................


Patch Set 1: Verified+1

unrelated test failure TsTabletManagerITest.TestTableStats (TSAN)


-- 
To view, visit http://gerrit.cloudera.org:8080/20608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c856135acad3eb13413f436adc9392923d42be8
Gerrit-Change-Number: 20608
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 21 Oct 2023 02:56:45 +0000
Gerrit-HasComments: No

[kudu-CR] [server] cleanup on setting JWT verifier for messenger

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20608 )

Change subject: [server] cleanup on setting JWT verifier for messenger
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c856135acad3eb13413f436adc9392923d42be8
Gerrit-Change-Number: 20608
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Sat, 21 Oct 2023 01:11:28 +0000
Gerrit-HasComments: No

[kudu-CR] [server] cleanup on setting JWT verifier for messenger

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20608 )

Change subject: [server] cleanup on setting JWT verifier for messenger
......................................................................

[server] cleanup on setting JWT verifier for messenger

This patch doesn't contain any functional modifications.

Change-Id: I1c856135acad3eb13413f436adc9392923d42be8
Reviewed-on: http://gerrit.cloudera.org:8080/20608
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/server/server_base.cc
1 file changed, 15 insertions(+), 20 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c856135acad3eb13413f436adc9392923d42be8
Gerrit-Change-Number: 20608
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>

[kudu-CR] [server] cleanup on setting JWT verifier for messenger

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [server] cleanup on setting JWT verifier for messenger
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/20608
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1c856135acad3eb13413f436adc9392923d42be8
Gerrit-Change-Number: 20608
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>