You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "lvyanquan (via GitHub)" <gi...@apache.org> on 2026/01/09 07:00:31 UTC
[PR] [FLINK-38877][common] Add variant type. [flink-cdc]
lvyanquan opened a new pull request, #4217:
URL: https://github.com/apache/flink-cdc/pull/4217
To facilitate review, only the Variant type is introduced here, and most of the code is copied from the Flink repository.
In the following prs, we will add related functions to generate data fields of this type and written to downstream systems like Paimon sink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38877][common] Add variant type. [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan merged PR #4217:
URL: https://github.com/apache/flink-cdc/pull/4217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38877][common] Add variant type. [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #4217:
URL: https://github.com/apache/flink-cdc/pull/4217#issuecomment-3736809733
Hi @yunfengzhou-hub, maybe you can help to review this when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38877][common] Add variant type. [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #4217:
URL: https://github.com/apache/flink-cdc/pull/4217#issuecomment-3727625949
Hi @leonardBang, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38877][common] Add variant type. [flink-cdc]
Posted by "yunfengzhou-hub (via GitHub)" <gi...@apache.org>.
yunfengzhou-hub commented on code in PR #4217:
URL: https://github.com/apache/flink-cdc/pull/4217#discussion_r2689490726
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/data/writer/BinaryWriter.java:
##########
Review Comment:
Do we need to add case for Variant in `BinaryArrayWriter` as well?
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/VariantSerializer.java:
##########
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.cdc.runtime.serializer;
+
+import org.apache.flink.api.common.typeutils.SimpleTypeSerializerSnapshot;
+import org.apache.flink.api.common.typeutils.TypeSerializerSnapshot;
+import org.apache.flink.api.common.typeutils.base.TypeSerializerSingleton;
+import org.apache.flink.cdc.common.annotation.Internal;
+import org.apache.flink.cdc.common.types.variant.BinaryVariant;
+import org.apache.flink.cdc.common.types.variant.Variant;
+import org.apache.flink.core.memory.DataInputView;
+import org.apache.flink.core.memory.DataOutputView;
+
+import java.io.IOException;
+import java.util.Arrays;
+
+/** Serializer for {@link Variant}. */
+@Internal
+public class VariantSerializer extends TypeSerializerSingleton<Variant> {
+
+ public static final VariantSerializer INSTANCE = new VariantSerializer();
+
+ @Override
+ public boolean isImmutableType() {
+ return false;
+ }
+
+ @Override
+ public Variant createInstance() {
+ return Variant.newBuilder().ofNull();
+ }
+
+ @Override
+ public Variant copy(Variant from) {
+ BinaryVariant binaryVariant = toBinaryVariant(from);
+ return new BinaryVariant(
+ Arrays.copyOf(binaryVariant.getValue(), binaryVariant.getValue().length),
+ Arrays.copyOf(binaryVariant.getMetadata(), binaryVariant.getMetadata().length));
+ }
+
+ @Override
+ public Variant copy(Variant from, Variant reuse) {
+ return copy(from);
+ }
+
+ @Override
+ public int getLength() {
+ return -1;
+ }
+
+ @Override
+ public void serialize(Variant record, DataOutputView target) throws IOException {
+
+ BinaryVariant binaryVariant = toBinaryVariant(record);
+
+ target.writeInt(binaryVariant.getValue().length);
+ target.writeInt(binaryVariant.getMetadata().length);
+ target.write(binaryVariant.getValue());
+ target.write(binaryVariant.getMetadata());
+ }
+
+ @Override
+ public Variant deserialize(DataInputView source) throws IOException {
+ int valueLength = source.readInt();
+ int metadataLength = source.readInt();
+ byte[] value = new byte[valueLength];
+ byte[] metaData = new byte[metadataLength];
+
+ source.read(value);
+ source.read(metaData);
+ return new BinaryVariant(value, metaData);
+ }
+
+ @Override
+ public Variant deserialize(Variant reuse, DataInputView source) throws IOException {
+ return this.deserialize(source);
+ }
+
+ @Override
+ public void copy(DataInputView source, DataOutputView target) throws IOException {
+ int valueLength = source.readInt();
+ int metadataLength = source.readInt();
+ target.writeInt(valueLength);
+ target.writeInt(metadataLength);
+ target.write(source, valueLength + metadataLength);
+ }
+
+ @Override
+ public TypeSerializerSnapshot<Variant> snapshotConfiguration() {
+ return new VariantSerializerSnapshot();
+ }
+
+ private BinaryVariant toBinaryVariant(Variant variant) {
+ if (variant instanceof BinaryVariant) {
+ return (BinaryVariant) variant;
+ }
+
+ throw new UnsupportedOperationException("Unsupported variant type: " + variant.getClass());
+ }
+
+ /** Snapshot class for the {@link VariantSerializer}. */
+ @org.apache.flink.annotation.Internal
Review Comment:
nit: `@Internal`
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/types/DataTypeVisitor.java:
##########
@@ -67,4 +67,8 @@ public interface DataTypeVisitor<R> {
R visit(MapType mapType);
R visit(RowType rowType);
+
+ default R visit(VariantType variantType) {
+ return null;
Review Comment:
Will `throw new UnsupportedOperationException` be a better choice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38877][common] Add variant type. [flink-cdc]
Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #4217:
URL: https://github.com/apache/flink-cdc/pull/4217#issuecomment-3752543025
Thanks @yunfengzhou-hub's comments, addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org