You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/21 08:58:37 UTC

[GitHub] [skywalking] dmsolr commented on pull request #7145: eliminate `now` error at a fixed rate schedule executor

dmsolr commented on pull request #7145:
URL: https://github.com/apache/skywalking/pull/7145#issuecomment-864860339


   Sorry for maybe I use the improper word about `error`.
   The period of calling `System.currentTimeMillis()` twice may not equal to `period of fetcher`.
   
   for example, the period of fetching = 10s, we can get the time list as follows,
   1624265391580
   1624265401585
   1624265411581
   1624265421582
   
   I set the duration as `PT10S`, and then CounterWindow needs to remove the `1624265401585` after `1624265411581`.
   But it is not removed because of `1624265411581 - 1624265401585 = 9996 < 10000`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org