You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/05/18 10:39:50 UTC
[GitHub] [cordova-browser] raphinesse commented on a change in pull request #96: breaking: @cordova/eslint-config w/ applied fix
raphinesse commented on a change in pull request #96:
URL: https://github.com/apache/cordova-browser/pull/96#discussion_r426532203
##########
File path: package.json
##########
@@ -18,9 +18,9 @@
],
"scripts": {
"cover": "nyc jasmine",
- "eslint": "eslint . \"bin/**/!(*.*)\"",
+ "lint": "eslint . \"bin/**/!(*.*|gitignore)\"",
Review comment:
No, unfortunately not. The second argument glob is necessary to also lint Node.js "binaries" that do not have a `.js` extension.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org