You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/03/14 03:37:00 UTC

Review Request 57584: RANGER-1449:There is logical inconsistency for RANGER_PID_DIR_PATH in security admin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57584/
-----------------------------------------------------------

Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-1449
    https://issues.apache.org/jira/browse/RANGER-1449


Repository: ranger


Description
-------

1. There is RANGER_PID_DIR_PATH parameter in install.properties. But There is hard code at the begin of setup.sh
pidFolderName='/var/run/ranger'
mkdir -p $
{pidFolderName}

if [ ! $? = "0" ];then
log "Make $pidFolderName failure....!!";
exit 1;
fi
2. The ranger-admin-services.sh will set default value and create default path when the RANGER_PID_DIR_PATH parameter is empty. The setup.sh doesn't set default value and create default path.


Diffs
-----

  security-admin/scripts/setup.sh 87be127 


Diff: https://reviews.apache.org/r/57584/diff/1/


Testing
-------


Thanks,

pengjianhua