You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2018/02/14 20:25:42 UTC
[5/8] maven git commit: Reduce number of global checkstyle rule
violations
Reduce number of global checkstyle rule violations
Fix code for following checkstyle rules:
ConstantName, FileLength, InnerAssignment, JavadocType, MagicNumber, MethodLength, MethodName, NewlineAtEndOfFile, ParameterNumber, RedundantThrows, VisibilityModifier
Fixes #149
Project: http://git-wip-us.apache.org/repos/asf/maven/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven/commit/d9250817
Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/d9250817
Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/d9250817
Branch: refs/heads/MNG-6352-print-version
Commit: d92508179410897404bcc7e826bb0877be2d08b8
Parents: 40cf506
Author: Sylwester Lachiewicz <sl...@gmail.com>
Authored: Thu Feb 1 22:57:39 2018 +0100
Committer: Hervé Boutemy <hb...@apache.org>
Committed: Sun Feb 11 11:41:16 2018 +0100
----------------------------------------------------------------------
.../apache/maven/artifact/ArtifactUtils.java | 3 ++
.../apache/maven/artifact/DefaultArtifact.java | 1 +
.../artifact/metadata/ArtifactMetadata.java | 3 ++
.../repository/ArtifactRepositoryPolicy.java | 1 +
.../artifact/repository/Authentication.java | 3 ++
.../layout/ArtifactRepositoryLayout2.java | 3 ++
.../artifact/versioning/ComparableVersion.java | 13 +++--
.../java/org/apache/maven/repository/Proxy.java | 3 ++
maven-compat/pom.xml | 4 --
.../artifact/deployer/ArtifactDeployer.java | 3 ++
.../deployer/DefaultArtifactDeployer.java | 3 ++
.../artifact/manager/DefaultWagonManager.java | 3 ++
.../repository/layout/FlatRepositoryLayout.java | 3 ++
.../repository/metadata/MetadataBridge.java | 2 +-
.../artifact/resolver/ArtifactCollector.java | 4 ++
.../artifact/resolver/ArtifactResolver.java | 1 +
.../resolver/DefaultArtifactCollector.java | 4 ++
.../resolver/DefaultArtifactResolver.java | 11 ++--
.../filter/InversionArtifactFilter.java | 3 ++
.../artifact/versioning/ManagedVersionMap.java | 3 ++
.../profiles/DefaultMavenProfilesBuilder.java | 3 ++
.../maven/profiles/DefaultProfileManager.java | 3 ++
.../apache/maven/profiles/ProfileManager.java | 3 ++
.../maven/profiles/ProfilesConversionUtils.java | 3 ++
.../activation/DetectedProfileActivator.java | 3 ++
.../activation/FileProfileActivator.java | 3 ++
.../activation/JdkPrefixProfileActivator.java | 3 ++
.../OperatingSystemProfileActivator.java | 3 ++
.../activation/ProfileActivationException.java | 3 ++
.../profiles/activation/ProfileActivator.java | 3 ++
.../SystemPropertyProfileActivator.java | 3 ++
.../DefaultProjectBuilderConfiguration.java | 3 ++
.../project/InvalidProjectModelException.java | 3 ++
.../MissingRepositoryElementException.java | 4 +-
.../org/apache/maven/project/ProjectUtils.java | 3 ++
.../DefaultModelInheritanceAssembler.java | 3 ++
.../StringSearchModelInterpolator.java | 7 ++-
.../project/path/DefaultPathTranslator.java | 3 ++
.../validation/DefaultModelValidator.java | 2 +-
.../maven/repository/DefaultMirrorSelector.java | 3 ++
.../repository/MetadataResolutionResult.java | 5 +-
.../repository/UserLocalArtifactRepository.java | 3 ++
.../legacy/DefaultUpdateCheckManager.java | 3 ++
.../repository/legacy/DefaultWagonManager.java | 5 ++
.../legacy/LegacyRepositorySystem.java | 2 +-
.../maven/repository/legacy/MavenArtifact.java | 2 +-
.../legacy/TransferListenerAdapter.java | 3 ++
.../repository/legacy/UpdateCheckManager.java | 3 ++
.../legacy/WagonConfigurationException.java | 4 +-
.../maven/repository/legacy/WagonManager.java | 3 ++
.../DefaultLegacyArtifactCollector.java | 4 ++
.../resolver/LegacyArtifactCollector.java | 1 +
.../ArtifactTransformationManager.java | 4 +-
.../transform/LatestArtifactTransformation.java | 3 ++
.../repository/metadata/ArtifactMetadata.java | 21 +++-----
.../repository/metadata/MetadataGraphEdge.java | 1 +
.../metadata/MetadataResolutionException.java | 3 ++
.../MetadataResolutionRequestTypeEnum.java | 3 ++
.../ExpressionDocumentationException.java | 3 ++
.../usability/plugin/ExpressionDocumenter.java | 3 ++
maven-core/pom.xml | 4 --
.../org/apache/maven/ArtifactFilterManager.java | 3 ++
.../DefaultProjectDependenciesResolver.java | 5 ++
.../src/main/java/org/apache/maven/Maven.java | 1 +
.../apache/maven/MissingModuleException.java | 3 ++
.../maven/ProjectDependenciesResolver.java | 2 +-
.../maven/artifact/factory/ArtifactFactory.java | 4 ++
.../factory/DefaultArtifactFactory.java | 5 ++
.../metadata/AbstractArtifactMetadata.java | 3 ++
.../ArtifactMetadataRetrievalException.java | 3 ++
.../metadata/ArtifactMetadataSource.java | 4 ++
.../artifact/metadata/ResolutionGroup.java | 3 ++
.../repository/MavenArtifactRepository.java | 4 ++
.../metadata/RepositoryMetadataManager.java | 3 ++
.../maven/artifact/resolver/ResolutionNode.java | 3 ++
.../maven/bridge/MavenRepositorySystem.java | 53 ++++++++++----------
.../org/apache/maven/eventspy/EventSpy.java | 4 +-
.../exception/DefaultExceptionHandler.java | 3 ++
.../DefaultMavenExecutionRequestPopulator.java | 3 ++
.../apache/maven/execution/MavenSession.java | 2 +
.../apache/maven/execution/ReactorManager.java | 3 ++
.../scope/internal/MojoExecutionScope.java | 7 ++-
.../internal/MojoExecutionScopeCoreModule.java | 3 ++
.../internal/MojoExecutionScopeModule.java | 3 ++
.../extension/internal/CoreExportsProvider.java | 3 ++
.../extension/internal/CoreExtensionEntry.java | 8 +--
.../apache/maven/graph/DefaultGraphBuilder.java | 3 ++
.../maven/lifecycle/MavenExecutionPlan.java | 3 ++
.../DefaultLifecycleMappingDelegate.java | 5 ++
.../internal/DefaultProjectArtifactFactory.java | 3 ++
.../internal/LifecycleDependencyResolver.java | 2 +-
.../builder/BuilderNotFoundException.java | 3 ++
.../multithreaded/ThreadOutputMuxer.java | 2 +-
.../singlethreaded/SingleThreadedBuilder.java | 5 ++
.../mapping/DefaultLifecycleMapping.java | 3 ++
.../lifecycle/mapping/LifecycleMapping.java | 3 ++
.../maven/lifecycle/mapping/LifecycleMojo.java | 3 ++
.../maven/lifecycle/mapping/LifecyclePhase.java | 3 ++
.../DefaultLifecycleBindingsInjector.java | 4 ++
.../maven/plugin/DefaultBuildPluginManager.java | 3 ++
.../plugin/DefaultExtensionRealmCache.java | 6 ++-
.../plugin/DefaultPluginArtifactsCache.java | 8 +--
.../maven/plugin/DefaultPluginRealmCache.java | 6 ++-
.../maven/plugin/ExtensionRealmCache.java | 23 +++++++--
.../InvalidPluginDescriptorException.java | 3 ++
.../maven/plugin/MavenPluginValidator.java | 3 ++
.../org/apache/maven/plugin/MojoExecution.java | 3 ++
.../maven/plugin/PluginArtifactsCache.java | 19 +++++--
.../maven/plugin/PluginExecutionException.java | 3 ++
.../maven/plugin/PluginParameterException.java | 3 ++
.../PluginParameterExpressionEvaluator.java | 1 +
.../apache/maven/plugin/PluginRealmCache.java | 20 ++++++--
.../internal/DefaultMavenPluginManager.java | 12 ++---
.../prefix/NoPluginFoundForPrefixException.java | 3 ++
.../version/PluginVersionNotFoundException.java | 3 ++
.../PluginVersionResolutionException.java | 3 ++
.../project/DefaultMavenProjectHelper.java | 3 ++
.../project/DefaultModelBuildingListener.java | 4 +-
.../maven/project/DefaultProjectBuilder.java | 24 +++++----
.../project/DefaultProjectBuildingHelper.java | 6 +--
.../project/DefaultProjectBuildingRequest.java | 3 ++
.../maven/project/DefaultProjectRealmCache.java | 6 ++-
.../project/InvalidProjectVersionException.java | 3 ++
.../maven/project/ProjectBuildingRequest.java | 3 ++
.../apache/maven/project/ProjectRealmCache.java | 17 ++++++-
.../org/apache/maven/project/ProjectSorter.java | 5 +-
.../apache/maven/project/ReactorModelPool.java | 2 +-
.../artifact/ArtifactWithDependencies.java | 3 ++
.../artifact/DefaultMavenMetadataCache.java | 9 ++++
.../artifact/DefaultProjectArtifactsCache.java | 8 +--
.../project/artifact/MavenMetadataCache.java | 3 ++
.../project/artifact/MavenMetadataSource.java | 2 +-
.../maven/project/artifact/PluginArtifact.java | 3 ++
.../maven/project/artifact/ProjectArtifact.java | 3 ++
.../project/artifact/ProjectArtifactsCache.java | 17 ++++++-
.../ArtifactDoesNotExistException.java | 3 ++
.../ArtifactTransferFailedException.java | 3 ++
.../repository/ArtifactTransferListener.java | 3 ++
.../repository/LocalArtifactRepository.java | 3 ++
.../maven/repository/RepositorySystem.java | 3 ++
.../legacy/metadata/ResolutionGroup.java | 3 ++
.../session/scope/internal/SessionScope.java | 12 +++--
.../scope/internal/SessionScopeModule.java | 3 ++
.../toolchain/merge/MavenToolchainMerger.java | 6 +--
.../project/LegacyLocalRepositoryManager.java | 2 +-
.../org/apache/maven/cli/CleanArgument.java | 3 ++
.../java/org/apache/maven/cli/CliRequest.java | 3 ++
.../java/org/apache/maven/cli/MavenCli.java | 4 +-
.../configuration/ConfigurationProcessor.java | 3 ++
.../SettingsXmlConfigurationProcessor.java | 3 ++
.../maven/cli/event/DefaultEventSpyContext.java | 3 ++
.../internal/BootstrapCoreExtensionManager.java | 3 ++
.../maven/cli/logging/Slf4jConfiguration.java | 3 ++
.../transfer/AbstractMavenTransferListener.java | 4 ++
.../BatchModeMavenTransferListener.java | 3 ++
.../transfer/Slf4jMavenTransferListener.java | 3 ++
.../model/building/DefaultModelBuilder.java | 2 +
.../model/building/DefaultModelProblem.java | 1 +
.../model/building/DefaultModelProcessor.java | 3 ++
.../apache/maven/model/building/ModelData.java | 2 +-
.../maven/model/building/ModelProblem.java | 3 ++
.../maven/model/building/ModelProblemUtils.java | 4 +-
.../maven/model/building/ModelProcessor.java | 3 ++
.../DefaultInheritanceAssembler.java | 4 ++
.../interpolation/MavenBuildTimestamp.java | 3 ++
.../StringSearchModelInterpolator.java | 3 ++
.../DefaultDependencyManagementInjector.java | 4 ++
.../DefaultPluginManagementInjector.java | 8 ++-
.../maven/model/merge/MavenModelMerger.java | 1 +
.../normalization/DefaultModelNormalizer.java | 3 ++
.../model/profile/DefaultProfileInjector.java | 4 ++
.../resolution/WorkspaceModelResolver.java | 3 ++
.../model/validation/DefaultModelValidator.java | 2 +
.../maven/plugin/MojoNotFoundException.java | 3 ++
.../DuplicateMojoDescriptorException.java | 3 ++
.../descriptor/DuplicateParameterException.java | 3 ++
.../InvalidPluginDescriptorException.java | 3 ++
.../descriptor/PluginDescriptorBuilder.java | 1 +
.../internal/DefaultVersionResolver.java | 3 +-
.../internal/MavenResolverModule.java | 3 ++
.../internal/MavenWorkspaceReader.java | 3 ++
.../slf4j/impl/MavenSimpleLoggerFactory.java | 3 ++
pom.xml | 2 +-
183 files changed, 658 insertions(+), 145 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java b/maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java
index 2c1bddd..cf7d27d 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/ArtifactUtils.java
@@ -29,6 +29,9 @@ import java.util.regex.Matcher;
import org.apache.commons.lang3.Validate;
import org.apache.maven.artifact.versioning.VersionRange;
+/**
+ * ArtifactUtils
+ */
public final class ArtifactUtils
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java b/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java
index bd2e8ed..1167e91 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/DefaultArtifact.java
@@ -94,6 +94,7 @@ public class DefaultArtifact
this( groupId, artifactId, versionRange, scope, type, classifier, artifactHandler, false );
}
+ @SuppressWarnings( "checkstyle:parameternumber" )
public DefaultArtifact( String groupId, String artifactId, VersionRange versionRange, String scope, String type,
String classifier, ArtifactHandler artifactHandler, boolean optional )
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-artifact/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadata.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadata.java b/maven-artifact/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadata.java
index 452c9f4..7bf8c61 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadata.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadata.java
@@ -19,6 +19,9 @@ package org.apache.maven.artifact.metadata;
* under the License.
*/
+/**
+ * Contains metadata about an artifact, and methods to retrieve/store it from an artifact repository.
+ */
@Deprecated
public interface ArtifactMetadata
extends org.apache.maven.repository.legacy.metadata.ArtifactMetadata
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java b/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java
index c5d2473..5a795e9 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/repository/ArtifactRepositoryPolicy.java
@@ -198,6 +198,7 @@ public class ArtifactRepositoryPolicy
}
}
+ @SuppressWarnings( "checkstyle:magicnumber" )
private int ordinalOfUpdatePolicy( String policy )
{
if ( ArtifactRepositoryPolicy.UPDATE_POLICY_DAILY.equals( policy ) )
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-artifact/src/main/java/org/apache/maven/artifact/repository/Authentication.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/repository/Authentication.java b/maven-artifact/src/main/java/org/apache/maven/artifact/repository/Authentication.java
index 323fb25..f02d1c5 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/repository/Authentication.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/repository/Authentication.java
@@ -19,6 +19,9 @@ package org.apache.maven.artifact.repository;
* under the License.
*/
+/**
+ * Authentication
+ */
public class Authentication
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-artifact/src/main/java/org/apache/maven/artifact/repository/layout/ArtifactRepositoryLayout2.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/repository/layout/ArtifactRepositoryLayout2.java b/maven-artifact/src/main/java/org/apache/maven/artifact/repository/layout/ArtifactRepositoryLayout2.java
index c0544e5..f6bc573 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/repository/layout/ArtifactRepositoryLayout2.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/repository/layout/ArtifactRepositoryLayout2.java
@@ -22,6 +22,9 @@ package org.apache.maven.artifact.repository.layout;
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.artifact.repository.ArtifactRepositoryPolicy;
+/**
+ * ArtifactRepositoryLayout2
+ */
public interface ArtifactRepositoryLayout2
extends ArtifactRepositoryLayout
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
index 8eb9a8f..4c64d2b 100644
--- a/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
+++ b/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
@@ -148,10 +148,8 @@ public class ComparableVersion
private static class StringItem
implements Item
{
- private static final String[] QUALIFIERS = { "alpha", "beta", "milestone", "rc", "snapshot", "", "sp" };
-
- @SuppressWarnings( "checkstyle:constantname" )
- private static final List<String> _QUALIFIERS = Arrays.asList( QUALIFIERS );
+ private static final List<String> QUALIFIERS =
+ Arrays.asList( "alpha", "beta", "milestone", "rc", "snapshot", "", "sp" );
private static final Properties ALIASES = new Properties();
static
@@ -165,7 +163,7 @@ public class ComparableVersion
* A comparable value for the empty-string qualifier. This one is used to determine if a given qualifier makes
* the version older than one without a qualifier, or more recent.
*/
- private static final String RELEASE_VERSION_INDEX = String.valueOf( _QUALIFIERS.indexOf( "" ) );
+ private static final String RELEASE_VERSION_INDEX = String.valueOf( QUALIFIERS.indexOf( "" ) );
private String value;
@@ -216,9 +214,9 @@ public class ComparableVersion
*/
public static String comparableQualifier( String qualifier )
{
- int i = _QUALIFIERS.indexOf( qualifier );
+ int i = QUALIFIERS.indexOf( qualifier );
- return i == -1 ? ( _QUALIFIERS.size() + "-" + qualifier ) : String.valueOf( i );
+ return i == -1 ? ( QUALIFIERS.size() + "-" + qualifier ) : String.valueOf( i );
}
public int compareTo( Item item )
@@ -350,6 +348,7 @@ public class ComparableVersion
parseVersion( version );
}
+ @SuppressWarnings( "checkstyle:innerassignment" )
public final void parseVersion( String version )
{
this.value = version;
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-artifact/src/main/java/org/apache/maven/repository/Proxy.java
----------------------------------------------------------------------
diff --git a/maven-artifact/src/main/java/org/apache/maven/repository/Proxy.java b/maven-artifact/src/main/java/org/apache/maven/repository/Proxy.java
index e42f1ed..960d7be 100644
--- a/maven-artifact/src/main/java/org/apache/maven/repository/Proxy.java
+++ b/maven-artifact/src/main/java/org/apache/maven/repository/Proxy.java
@@ -19,6 +19,9 @@ package org.apache.maven.repository;
* under the License.
*/
+/**
+ * Proxy
+ */
public class Proxy
{
public static final String PROXY_SOCKS5 = "SOCKS_5";
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/pom.xml
----------------------------------------------------------------------
diff --git a/maven-compat/pom.xml b/maven-compat/pom.xml
index 7ec94e2..20de667 100644
--- a/maven-compat/pom.xml
+++ b/maven-compat/pom.xml
@@ -33,10 +33,6 @@ under the License.
<name>Maven Compat</name>
<description>Maven2 classes maintained as compatibility layer.</description>
- <properties>
- <checkstyle.failOnViolation>false</checkstyle.failOnViolation><!-- laziness for code that will disappear in future... -->
- </properties>
-
<dependencies>
<dependency>
<groupId>org.apache.maven</groupId>
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/deployer/ArtifactDeployer.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/deployer/ArtifactDeployer.java b/maven-compat/src/main/java/org/apache/maven/artifact/deployer/ArtifactDeployer.java
index 072552c..bf15206 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/deployer/ArtifactDeployer.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/deployer/ArtifactDeployer.java
@@ -24,6 +24,9 @@ import java.io.File;
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.repository.ArtifactRepository;
+/**
+ * ArtifactDeployer
+ */
public interface ArtifactDeployer
{
String ROLE = ArtifactDeployer.class.getName();
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java b/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java
index 1463c5a..87d9c46 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java
@@ -47,6 +47,9 @@ import org.eclipse.aether.metadata.MergeableMetadata;
import org.eclipse.aether.repository.RemoteRepository;
import org.eclipse.aether.util.artifact.SubArtifact;
+/**
+ * DefaultArtifactDeployer
+ */
@Component( role = ArtifactDeployer.class, instantiationStrategy = "per-lookup" )
public class DefaultArtifactDeployer
extends AbstractLogEnabled
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java b/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
index fe89d1e..5f7957e 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/manager/DefaultWagonManager.java
@@ -42,6 +42,9 @@ import org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
import org.codehaus.plexus.logging.Logger;
+/**
+ * Manages <a href="https://maven.apache.org/wagon">Wagon</a> related operations in Maven.
+ */
@Component( role = WagonManager.class )
public class DefaultWagonManager
extends org.apache.maven.repository.legacy.DefaultWagonManager
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java b/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
index 58143e0..4426611 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
@@ -25,6 +25,9 @@ import org.apache.maven.artifact.metadata.ArtifactMetadata;
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.codehaus.plexus.component.annotations.Component;
+/**
+ * FlatRepositoryLayout
+ */
@Component( role = ArtifactRepositoryLayout.class, hint = "flat" )
public class FlatRepositoryLayout
implements ArtifactRepositoryLayout
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/MetadataBridge.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/MetadataBridge.java b/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/MetadataBridge.java
index bf19921..0fd49dd 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/MetadataBridge.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/repository/metadata/MetadataBridge.java
@@ -149,7 +149,7 @@ public final class MetadataBridge
private File metadataFile;
- public MetadataRepository( File metadataFile )
+ MetadataRepository( File metadataFile )
{
super( "local", "", null );
this.metadataFile = metadataFile;
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactCollector.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactCollector.java b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactCollector.java
index 5ef8602..3526be4 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactCollector.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactCollector.java
@@ -27,6 +27,10 @@ import org.apache.maven.artifact.metadata.ArtifactMetadataSource;
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
+/**
+ * Artifact collector - takes a set of original artifacts and resolves all of the best versions to use
+ * along with their metadata. No artifacts are downloaded.
+ */
@Deprecated
public interface ArtifactCollector
extends org.apache.maven.repository.legacy.resolver.LegacyArtifactCollector
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolver.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolver.java b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolver.java
index d36ebde..45204f8 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolver.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/ArtifactResolver.java
@@ -79,6 +79,7 @@ public interface ArtifactResolver
throws ArtifactResolutionException, ArtifactNotFoundException;
@Deprecated
+ @SuppressWarnings( "checkstyle:parameternumber" )
ArtifactResolutionResult resolveTransitively(
Set<Artifact> artifacts, Artifact originatingArtifact,
Map<String, Artifact> managedVersions, ArtifactRepository localRepository,
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
index cefb9e2..25e92c4 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactCollector.java
@@ -21,6 +21,10 @@ package org.apache.maven.artifact.resolver;
import org.codehaus.plexus.component.annotations.Component;
+/**
+ * Artifact collector - takes a set of original artifacts and resolves all of the best versions to use
+ * along with their metadata. No artifacts are downloaded.
+ */
@Deprecated
@Component( role = ArtifactCollector.class )
public class DefaultArtifactCollector
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java
index 915ee72..2d1d8d9 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/DefaultArtifactResolver.java
@@ -258,7 +258,8 @@ public class DefaultArtifactResolver
throws ArtifactResolutionException,
ArtifactNotFoundException
{
- return resolveTransitively( artifacts, originatingArtifact, Collections.<String, Artifact>emptyMap(), localRepository,
+ return resolveTransitively(
+ artifacts, originatingArtifact, Collections.<String, Artifact>emptyMap(), localRepository,
remoteRepositories, source, filter );
}
@@ -305,10 +306,12 @@ public class DefaultArtifactResolver
throws ArtifactResolutionException,
ArtifactNotFoundException
{
- return resolveTransitively( artifacts, originatingArtifact, Collections.<String, Artifact>emptyMap(), localRepository,
+ return resolveTransitively(
+ artifacts, originatingArtifact, Collections.<String, Artifact>emptyMap(), localRepository,
remoteRepositories, source, null, listeners );
}
+ @SuppressWarnings( "checkstyle:parameternumber" )
public ArtifactResolutionResult resolveTransitively( Set<Artifact> artifacts, Artifact originatingArtifact,
Map<String, Artifact> managedVersions,
ArtifactRepository localRepository,
@@ -322,6 +325,7 @@ public class DefaultArtifactResolver
remoteRepositories, source, filter, listeners, null );
}
+ @SuppressWarnings( "checkstyle:parameternumber" )
public ArtifactResolutionResult resolveTransitively( Set<Artifact> artifacts, Artifact originatingArtifact,
Map<String, Artifact> managedVersions,
ArtifactRepository localRepository,
@@ -366,6 +370,7 @@ public class DefaultArtifactResolver
//
// ------------------------------------------------------------------------
+ @SuppressWarnings( "checkstyle:methodlength" )
public ArtifactResolutionResult resolve( ArtifactResolutionRequest request )
{
Artifact rootArtifact = request.getArtifact();
@@ -599,7 +604,7 @@ public class DefaultArtifactResolver
private final ArtifactResolutionResult result;
- public ResolveTask( ClassLoader classLoader, CountDownLatch latch, Artifact artifact,
+ ResolveTask( ClassLoader classLoader, CountDownLatch latch, Artifact artifact,
RepositorySystemSession session, List<ArtifactRepository> remoteRepositories,
ArtifactResolutionResult result )
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/resolver/filter/InversionArtifactFilter.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/filter/InversionArtifactFilter.java b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/filter/InversionArtifactFilter.java
index 0499db5..fa66574 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/resolver/filter/InversionArtifactFilter.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/resolver/filter/InversionArtifactFilter.java
@@ -21,6 +21,9 @@ package org.apache.maven.artifact.resolver.filter;
import org.apache.maven.artifact.Artifact;
+/**
+ * InversionArtifactFilter
+ */
public class InversionArtifactFilter
implements ArtifactFilter
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java b/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java
index 02ac24c..c098d7f 100644
--- a/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java
+++ b/maven-compat/src/main/java/org/apache/maven/artifact/versioning/ManagedVersionMap.java
@@ -25,6 +25,9 @@ import java.util.Map;
import org.apache.maven.artifact.Artifact;
+/**
+ * ManagedVersionMap
+ */
@Deprecated
public class ManagedVersionMap
extends HashMap<String, Artifact>
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/DefaultMavenProfilesBuilder.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/DefaultMavenProfilesBuilder.java b/maven-compat/src/main/java/org/apache/maven/profiles/DefaultMavenProfilesBuilder.java
index 98ff3d0..8ee9001 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/DefaultMavenProfilesBuilder.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/DefaultMavenProfilesBuilder.java
@@ -34,6 +34,9 @@ import java.io.Reader;
import java.io.StringReader;
import java.io.StringWriter;
+/**
+ * DefaultMavenProfilesBuilder
+ */
@Deprecated
@Component( role = MavenProfilesBuilder.class )
public class DefaultMavenProfilesBuilder
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java b/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
index e3e0cb7..9890622 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/DefaultProfileManager.java
@@ -39,6 +39,9 @@ import java.util.Map;
import java.util.Properties;
import org.apache.maven.model.building.ModelProblemCollectorRequest;
+/**
+ * DefaultProfileManager
+ */
@Deprecated
public class DefaultProfileManager
implements ProfileManager
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/ProfileManager.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/ProfileManager.java b/maven-compat/src/main/java/org/apache/maven/profiles/ProfileManager.java
index 98064ef..5fab100 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/ProfileManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/ProfileManager.java
@@ -26,6 +26,9 @@ import java.util.List;
import java.util.Map;
import java.util.Properties;
+/**
+ * ProfileManager
+ */
@Deprecated
public interface ProfileManager
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/ProfilesConversionUtils.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/ProfilesConversionUtils.java b/maven-compat/src/main/java/org/apache/maven/profiles/ProfilesConversionUtils.java
index 72527b0..154176e 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/ProfilesConversionUtils.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/ProfilesConversionUtils.java
@@ -27,6 +27,9 @@ import org.apache.maven.model.Repository;
import java.util.List;
+/**
+ * ProfilesConversionUtils
+ */
@Deprecated
public class ProfilesConversionUtils
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/activation/DetectedProfileActivator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/DetectedProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/DetectedProfileActivator.java
index 5d6a8bf..f034245 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/DetectedProfileActivator.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/DetectedProfileActivator.java
@@ -21,6 +21,9 @@ package org.apache.maven.profiles.activation;
import org.apache.maven.model.Profile;
+/**
+ * DetectedProfileActivator
+ */
@Deprecated
public abstract class DetectedProfileActivator
implements ProfileActivator
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java
index de4ba2e..e7044f5 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/FileProfileActivator.java
@@ -33,6 +33,9 @@ import org.codehaus.plexus.logging.Logger;
import org.codehaus.plexus.util.FileUtils;
import org.codehaus.plexus.util.StringUtils;
+/**
+ * FileProfileActivator
+ */
@Deprecated
public class FileProfileActivator
extends DetectedProfileActivator
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java
index dfae95f..1c835f8 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/JdkPrefixProfileActivator.java
@@ -26,6 +26,9 @@ import org.apache.maven.model.Activation;
import org.apache.maven.model.Profile;
import org.codehaus.plexus.util.StringUtils;
+/**
+ * JdkPrefixProfileActivator
+ */
@Deprecated
public class JdkPrefixProfileActivator
extends DetectedProfileActivator
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java
index 7464a30..378c3c9 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/OperatingSystemProfileActivator.java
@@ -24,6 +24,9 @@ import org.apache.maven.model.ActivationOS;
import org.apache.maven.model.Profile;
import org.codehaus.plexus.util.Os;
+/**
+ * OperatingSystemProfileActivator
+ */
@Deprecated
public class OperatingSystemProfileActivator
implements ProfileActivator
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivationException.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivationException.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivationException.java
index 7fc372c..59f70be 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivationException.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivationException.java
@@ -19,6 +19,9 @@ package org.apache.maven.profiles.activation;
* under the License.
*/
+/**
+ * ProfileActivationException
+ */
@Deprecated
public class ProfileActivationException
extends Exception
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivator.java
index 2688785..6482018 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivator.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/ProfileActivator.java
@@ -21,6 +21,9 @@ package org.apache.maven.profiles.activation;
import org.apache.maven.model.Profile;
+/**
+ * ProfileActivator
+ */
@Deprecated
public interface ProfileActivator
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java b/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java
index a03267d..d7e4003 100644
--- a/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java
+++ b/maven-compat/src/main/java/org/apache/maven/profiles/activation/SystemPropertyProfileActivator.java
@@ -28,6 +28,9 @@ import org.codehaus.plexus.context.ContextException;
import org.codehaus.plexus.personality.plexus.lifecycle.phase.Contextualizable;
import org.codehaus.plexus.util.StringUtils;
+/**
+ * SystemPropertyProfileActivator
+ */
@Deprecated
public class SystemPropertyProfileActivator
extends DetectedProfileActivator implements Contextualizable
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/project/DefaultProjectBuilderConfiguration.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/DefaultProjectBuilderConfiguration.java b/maven-compat/src/main/java/org/apache/maven/project/DefaultProjectBuilderConfiguration.java
index d08f18e..aca6a03 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/DefaultProjectBuilderConfiguration.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/DefaultProjectBuilderConfiguration.java
@@ -25,6 +25,9 @@ import java.util.Properties;
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.profiles.ProfileManager;
+/**
+ * DefaultProjectBuilderConfiguration
+ */
@Deprecated
public class DefaultProjectBuilderConfiguration
implements ProjectBuilderConfiguration
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/project/InvalidProjectModelException.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/InvalidProjectModelException.java b/maven-compat/src/main/java/org/apache/maven/project/InvalidProjectModelException.java
index cf85aa9..d7241fd 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/InvalidProjectModelException.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/InvalidProjectModelException.java
@@ -23,6 +23,9 @@ import java.io.File;
import org.apache.maven.project.validation.ModelValidationResult;
+/**
+ * InvalidProjectModelException
+ */
@Deprecated
public class InvalidProjectModelException
extends ProjectBuildingException
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/project/MissingRepositoryElementException.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/MissingRepositoryElementException.java b/maven-compat/src/main/java/org/apache/maven/project/MissingRepositoryElementException.java
index 17c267e..75384e1 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/MissingRepositoryElementException.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/MissingRepositoryElementException.java
@@ -20,7 +20,9 @@ package org.apache.maven.project;
*/
import org.apache.maven.artifact.InvalidRepositoryException;
-
+/**
+ * Error constructing an artifact repository.
+ */
public class MissingRepositoryElementException
extends InvalidRepositoryException
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/project/ProjectUtils.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/ProjectUtils.java b/maven-compat/src/main/java/org/apache/maven/project/ProjectUtils.java
index 72ea6d1..21a4ac7 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/ProjectUtils.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/ProjectUtils.java
@@ -37,6 +37,9 @@ import org.eclipse.aether.RepositorySystemSession;
// This class needs to stick around because it was exposed the the remote resources plugin started using it instead of
// getting the repositories from the project.
+/**
+ * ProjectUtils
+ */
@Deprecated
public final class ProjectUtils
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java b/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
index 07e9473..81ea92d 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java
@@ -47,6 +47,9 @@ import org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.util.StringUtils;
import org.codehaus.plexus.util.xml.Xpp3Dom;
+/**
+ * DefaultModelInheritanceAssembler
+ */
@Component( role = ModelInheritanceAssembler.class )
public class DefaultModelInheritanceAssembler
implements ModelInheritanceAssembler
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/project/interpolation/StringSearchModelInterpolator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/interpolation/StringSearchModelInterpolator.java b/maven-compat/src/main/java/org/apache/maven/project/interpolation/StringSearchModelInterpolator.java
index ecde27f..f137c6e 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/interpolation/StringSearchModelInterpolator.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/interpolation/StringSearchModelInterpolator.java
@@ -41,6 +41,9 @@ import java.util.List;
import java.util.Map;
import java.util.WeakHashMap;
+/**
+ * StringSearchModelInterpolator
+ */
@Deprecated
@Component( role = ModelInterpolator.class )
public class StringSearchModelInterpolator
@@ -111,7 +114,7 @@ public class StringSearchModelInterpolator
private final List<ValueSource> valueSources;
private final List<InterpolationPostProcessor> postProcessors;
- public InterpolateObjectAction( Object target, List<ValueSource> valueSources,
+ InterpolateObjectAction( Object target, List<ValueSource> valueSources,
List<InterpolationPostProcessor> postProcessors, boolean debugEnabled,
StringSearchModelInterpolator modelInterpolator, Logger logger )
{
@@ -145,7 +148,7 @@ public class StringSearchModelInterpolator
return null;
}
- @SuppressWarnings( "unchecked" )
+ @SuppressWarnings( { "unchecked", "checkstyle:methodlength" } )
private void traverseObjectWithParents( Class<?> cls, Object target )
throws ModelInterpolationException
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java b/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java
index eb3f24d..79e1f41 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/path/DefaultPathTranslator.java
@@ -29,6 +29,9 @@ import org.apache.maven.model.Reporting;
import org.apache.maven.model.Resource;
import org.codehaus.plexus.component.annotations.Component;
+/**
+ * DefaultPathTranslator
+ */
@Deprecated
@Component( role = PathTranslator.class )
public class DefaultPathTranslator
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java b/maven-compat/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
index 0095f80..6406b58 100644
--- a/maven-compat/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
+++ b/maven-compat/src/main/java/org/apache/maven/project/validation/DefaultModelValidator.java
@@ -60,7 +60,7 @@ public class DefaultModelValidator
ModelValidationResult result;
- public SimpleModelProblemCollector( ModelValidationResult result )
+ SimpleModelProblemCollector( ModelValidationResult result )
{
this.result = result;
}
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java b/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java
index 53e7bd4..6fa2c55 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/DefaultMirrorSelector.java
@@ -29,6 +29,9 @@ import org.apache.maven.settings.Mirror;
import org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.util.StringUtils;
+/**
+ * DefaultMirrorSelector
+ */
@Component( role = MirrorSelector.class )
public class DefaultMirrorSelector
implements MirrorSelector
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java b/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java
index 28fb723..70b9c3f 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/MetadataResolutionResult.java
@@ -74,7 +74,7 @@ public class MetadataResolutionResult
return originatingArtifact;
}
- public MetadataResolutionResult ListOriginatingArtifact( final Artifact originatingArtifact )
+ public MetadataResolutionResult listOriginatingArtifact( final Artifact originatingArtifact )
{
this.originatingArtifact = originatingArtifact;
@@ -323,8 +323,9 @@ public class MetadataResolutionResult
public String toString()
{
if ( artifacts == null )
+ {
return "";
-
+ }
StringBuilder sb = new StringBuilder( 256 );
int i = 1;
sb.append( "---------\n" );
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/UserLocalArtifactRepository.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/UserLocalArtifactRepository.java b/maven-compat/src/main/java/org/apache/maven/repository/UserLocalArtifactRepository.java
index 70d3e0a..a88b009 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/UserLocalArtifactRepository.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/UserLocalArtifactRepository.java
@@ -25,6 +25,9 @@ import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.metadata.ArtifactMetadata;
import org.apache.maven.artifact.repository.ArtifactRepository;
+/**
+ * UserLocalArtifactRepository
+ */
public class UserLocalArtifactRepository
extends LocalArtifactRepository
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
index 4839d68..cd01ec9 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManager.java
@@ -39,6 +39,9 @@ import java.nio.channels.FileLock;
import java.util.Date;
import java.util.Properties;
+/**
+ * DefaultUpdateCheckManager
+ */
@Component( role = UpdateCheckManager.class )
public class DefaultUpdateCheckManager
extends AbstractLogEnabled
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java
index 8dd6b36..d8f590b 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/DefaultWagonManager.java
@@ -59,6 +59,10 @@ import org.eclipse.aether.util.ConfigUtils;
//TODO remove the update check manager
//TODO separate into retriever and publisher
//TODO remove hardcoding of checksum logic
+
+/**
+ * Manages <a href="https://maven.apache.org/wagon">Wagon</a> related operations in Maven.
+ */
@Component( role = WagonManager.class )
public class DefaultWagonManager
implements WagonManager
@@ -333,6 +337,7 @@ public class DefaultWagonManager
return proxyInfo;
}
+ @SuppressWarnings( "checkstyle:methodlength" )
@Override
public void getRemoteFile( ArtifactRepository repository, File destination, String remotePath,
TransferListener downloadMonitor, String checksumPolicy, boolean force )
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/LegacyRepositorySystem.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/LegacyRepositorySystem.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/LegacyRepositorySystem.java
index 8d4d407..0acab4f 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/LegacyRepositorySystem.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/LegacyRepositorySystem.java
@@ -882,7 +882,7 @@ public class LegacyRepositorySystem
private final ArtifactRepositoryLayout fallback;
- public UnknownRepositoryLayout( String id, ArtifactRepositoryLayout fallback )
+ UnknownRepositoryLayout( String id, ArtifactRepositoryLayout fallback )
{
this.id = id;
this.fallback = fallback;
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java
index 29b9b82..07d2cdb 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/MavenArtifact.java
@@ -32,7 +32,7 @@ class MavenArtifact
private long transferStartTime;
- public MavenArtifact( String repositoryUrl, Resource resource )
+ MavenArtifact( String repositoryUrl, Resource resource )
{
if ( repositoryUrl == null )
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/TransferListenerAdapter.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/TransferListenerAdapter.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/TransferListenerAdapter.java
index 017dd9b..c3bc5e9 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/TransferListenerAdapter.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/TransferListenerAdapter.java
@@ -30,6 +30,9 @@ import org.apache.maven.wagon.events.TransferListener;
import org.apache.maven.wagon.repository.Repository;
import org.apache.maven.wagon.resource.Resource;
+/**
+ * TransferListenerAdapter
+ */
public class TransferListenerAdapter
implements TransferListener
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/UpdateCheckManager.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/UpdateCheckManager.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/UpdateCheckManager.java
index f4e969b..0ef8c6a 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/UpdateCheckManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/UpdateCheckManager.java
@@ -25,6 +25,9 @@ import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.artifact.repository.metadata.RepositoryMetadata;
+/**
+ * UpdateCheckManager
+ */
public interface UpdateCheckManager
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonConfigurationException.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonConfigurationException.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonConfigurationException.java
index 078de00..5542125 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonConfigurationException.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonConfigurationException.java
@@ -21,7 +21,9 @@ package org.apache.maven.repository.legacy;
import org.apache.maven.wagon.TransferFailedException;
-
+/**
+ * WagonConfigurationException
+ */
public class WagonConfigurationException
extends TransferFailedException
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonManager.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonManager.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonManager.java
index 35fcf42..6156818 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/WagonManager.java
@@ -32,6 +32,9 @@ import org.apache.maven.wagon.Wagon;
import org.apache.maven.wagon.events.TransferListener;
import org.apache.maven.wagon.repository.Repository;
+/**
+ * WagonManager
+ */
public interface WagonManager
{
@Deprecated
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java
index c3603a6..ffc9e9a 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java
@@ -87,6 +87,7 @@ public class DefaultLegacyArtifactCollector
}
}
+ @SuppressWarnings( "checkstyle:parameternumber" )
public ArtifactResolutionResult collect( Set<Artifact> artifacts, Artifact originatingArtifact,
Map<String, Artifact> managedVersions, ArtifactRepository localRepository,
List<ArtifactRepository> remoteRepositories,
@@ -102,6 +103,7 @@ public class DefaultLegacyArtifactCollector
conflictResolvers );
}
+ @SuppressWarnings( "checkstyle:parameternumber" )
public ArtifactResolutionResult collect( Set<Artifact> artifacts, Artifact originatingArtifact,
Map<String, Artifact> managedVersions,
ArtifactResolutionRequest repositoryRequest,
@@ -239,6 +241,7 @@ public class DefaultLegacyArtifactCollector
return versionMap;
}
+ @SuppressWarnings( { "checkstyle:parameternumber", "checkstyle:methodlength" } )
private void recurse( ArtifactResolutionResult result, ResolutionNode node,
Map<Object, List<ResolutionNode>> resolvedArtifacts, ManagedVersionMap managedVersions,
ArtifactResolutionRequest request, ArtifactMetadataSource source, ArtifactFilter filter,
@@ -791,6 +794,7 @@ public class DefaultLegacyArtifactCollector
}
}
+ @SuppressWarnings( "checkstyle:parameternumber" )
public ArtifactResolutionResult collect( Set<Artifact> artifacts, Artifact originatingArtifact,
Map<String, Artifact> managedVersions, ArtifactRepository localRepository,
List<ArtifactRepository> remoteRepositories,
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/LegacyArtifactCollector.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/LegacyArtifactCollector.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/LegacyArtifactCollector.java
index 4045258..90b869f 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/LegacyArtifactCollector.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/LegacyArtifactCollector.java
@@ -39,6 +39,7 @@ import org.apache.maven.repository.legacy.resolver.conflict.ConflictResolver;
* @author <a href="mailto:brett@apache.org">Brett Porter</a>
*/
@Deprecated
+@SuppressWarnings( "checkstyle:parameternumber" )
public interface LegacyArtifactCollector
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/ArtifactTransformationManager.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/ArtifactTransformationManager.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/ArtifactTransformationManager.java
index 95f15f9..ed3ee9a 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/ArtifactTransformationManager.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/ArtifactTransformationManager.java
@@ -29,7 +29,9 @@ import org.apache.maven.artifact.repository.RepositoryRequest;
import org.apache.maven.artifact.resolver.ArtifactNotFoundException;
import org.apache.maven.artifact.resolver.ArtifactResolutionException;
-/** Manages multiple ArtifactTransformation instances and applies them in succession. */
+/**
+ * Manages multiple ArtifactTransformation instances and applies them in succession.
+ */
public interface ArtifactTransformationManager
{
String ROLE = ArtifactTransformationManager.class.getName();
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/LatestArtifactTransformation.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/LatestArtifactTransformation.java b/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/LatestArtifactTransformation.java
index 7b0e851..0bc89c1 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/LatestArtifactTransformation.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/legacy/resolver/transform/LatestArtifactTransformation.java
@@ -28,6 +28,9 @@ import org.apache.maven.artifact.resolver.ArtifactNotFoundException;
import org.apache.maven.artifact.resolver.ArtifactResolutionException;
import org.codehaus.plexus.component.annotations.Component;
+/**
+ * Describes a version transformation during artifact resolution - "latest" type
+ */
@Component( role = ArtifactTransformation.class, hint = "latest" )
public class LatestArtifactTransformation
extends AbstractVersionTransformation
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/metadata/ArtifactMetadata.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/metadata/ArtifactMetadata.java b/maven-compat/src/main/java/org/apache/maven/repository/metadata/ArtifactMetadata.java
index 2666eaf..13b00c3 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/metadata/ArtifactMetadata.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/metadata/ArtifactMetadata.java
@@ -94,36 +94,34 @@ public class ArtifactMetadata
}
}
- // ------------------------------------------------------------------
public ArtifactMetadata( String groupId, String name, String version )
{
this( groupId, name, version, null );
}
- //------------------------------------------------------------------
+
public ArtifactMetadata( String groupId, String name, String version, String type )
{
this( groupId, name, version, type, null );
}
- //------------------------------------------------------------------
public ArtifactMetadata( String groupId, String name, String version, String type, ArtifactScopeEnum artifactScope )
{
this( groupId, name, version, type, artifactScope, null );
}
- //------------------------------------------------------------------
public ArtifactMetadata( String groupId, String name, String version, String type, ArtifactScopeEnum artifactScope,
String classifier )
{
this( groupId, name, version, type, artifactScope, classifier, null );
}
- //------------------------------------------------------------------
+
public ArtifactMetadata( String groupId, String name, String version, String type, ArtifactScopeEnum artifactScope,
String classifier, String artifactUri )
{
this( groupId, name, version, type, artifactScope, classifier, artifactUri, null, true, null );
}
- //------------------------------------------------------------------
+
+ @SuppressWarnings( "checkstyle:parameternumber" )
public ArtifactMetadata( String groupId, String name, String version, String type, ArtifactScopeEnum artifactScope,
String classifier, String artifactUri, String why, boolean resolved, String error )
{
@@ -138,7 +136,8 @@ public class ArtifactMetadata
this.resolved = resolved;
this.error = error;
}
- //------------------------------------------------------------------
+
+ @SuppressWarnings( "checkstyle:parameternumber" )
public ArtifactMetadata( String groupId, String name, String version, String type, String scopeString,
String classifier, String artifactUri, String why, boolean resolved, String error )
{
@@ -147,7 +146,6 @@ public class ArtifactMetadata
classifier, artifactUri, why, resolved, error );
}
- //------------------------------------------------------------------
public ArtifactMetadata( Artifact af )
{
/*
@@ -171,20 +169,17 @@ public class ArtifactMetadata
// this.resolved = af.isResolved();
// }
- //------------------------------------------------------------------
@Override
public String toString()
{
return groupId + ":" + artifactId + ":" + version;
}
- //------------------------------------------------------------------
public String toDomainString()
{
return groupId + ":" + artifactId;
}
- //------------------------------------------------------------------
public String getGroupId()
{
return groupId;
@@ -327,7 +322,6 @@ public class ArtifactMetadata
this.why = why;
}
- //-------------------------------------------------------------------
public String getError()
{
return error;
@@ -343,11 +337,8 @@ public class ArtifactMetadata
return error == null;
}
- //------------------------------------------------------------------
public String getDependencyConflictId()
{
return groupId + ":" + artifactId;
}
- //------------------------------------------------------------------
- //------------------------------------------------------------------
}
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphEdge.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphEdge.java b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphEdge.java
index 5a4c106..16fe9bc 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphEdge.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataGraphEdge.java
@@ -81,6 +81,7 @@ public class MetadataGraphEdge
* used to eliminate exact duplicates in the edge list
*/
@Override
+ @SuppressWarnings( "checkstyle:equalshashcode" )
public boolean equals( Object o )
{
if ( o instanceof MetadataGraphEdge )
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionException.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionException.java b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionException.java
index 24f832e..149d2ac 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionException.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionException.java
@@ -19,6 +19,9 @@ package org.apache.maven.repository.metadata;
* under the License.
*/
+/**
+ * MetadataResolutionException
+ */
public class MetadataResolutionException
extends Exception
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionRequestTypeEnum.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionRequestTypeEnum.java b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionRequestTypeEnum.java
index f305497..31e3e91 100644
--- a/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionRequestTypeEnum.java
+++ b/maven-compat/src/main/java/org/apache/maven/repository/metadata/MetadataResolutionRequestTypeEnum.java
@@ -19,6 +19,9 @@ package org.apache.maven.repository.metadata;
* under the License.
*/
+/**
+ * MetadataResolutionRequestTypeEnum
+ */
public enum MetadataResolutionRequestTypeEnum
{
tree( 1 )
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumentationException.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumentationException.java b/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumentationException.java
index 050d135..d001562 100644
--- a/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumentationException.java
+++ b/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumentationException.java
@@ -19,6 +19,9 @@ package org.apache.maven.usability.plugin;
* under the License.
*/
+/**
+ * ExpressionDocumentationException
+ */
public class ExpressionDocumentationException
extends Exception
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumenter.java
----------------------------------------------------------------------
diff --git a/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumenter.java b/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumenter.java
index b5e606d..f4e7bf9 100644
--- a/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumenter.java
+++ b/maven-compat/src/main/java/org/apache/maven/usability/plugin/ExpressionDocumenter.java
@@ -35,6 +35,9 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
+/**
+ * ExpressionDocumenter
+ */
public class ExpressionDocumenter
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/pom.xml
----------------------------------------------------------------------
diff --git a/maven-core/pom.xml b/maven-core/pom.xml
index 7c2cde1..751fd53 100644
--- a/maven-core/pom.xml
+++ b/maven-core/pom.xml
@@ -33,10 +33,6 @@ under the License.
<name>Maven Core</name>
<description>Maven Core classes.</description>
- <properties>
- <checkstyle.violation.ignore>RedundantThrows,NewlineAtEndOfFile,ParameterNumber,MethodLength,FileLength,JavadocType,MethodName,MagicNumber,ConstantName,VisibilityModifier,InnerAssignment</checkstyle.violation.ignore>
- </properties>
-
<dependencies>
<!-- Maven -->
<dependency>
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/ArtifactFilterManager.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/ArtifactFilterManager.java b/maven-core/src/main/java/org/apache/maven/ArtifactFilterManager.java
index 2cf9f99..e15037e 100644
--- a/maven-core/src/main/java/org/apache/maven/ArtifactFilterManager.java
+++ b/maven-core/src/main/java/org/apache/maven/ArtifactFilterManager.java
@@ -23,6 +23,9 @@ import java.util.Set;
import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
+/**
+ * ArtifactFilterManager
+ */
public interface ArtifactFilterManager
{
/**
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResolver.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResolver.java b/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResolver.java
index be7c97a..dca8014 100644
--- a/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResolver.java
+++ b/maven-core/src/main/java/org/apache/maven/DefaultProjectDependenciesResolver.java
@@ -42,6 +42,11 @@ import org.apache.maven.repository.RepositorySystem;
import org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
+/**
+ * @deprecated As of 3.2.2, and there is no direct replacement. This is an internal class which was not marked as such,
+ * but should have been.
+ *
+ */
@Deprecated
@Component( role = ProjectDependenciesResolver.class )
public class DefaultProjectDependenciesResolver
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/Maven.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/Maven.java b/maven-core/src/main/java/org/apache/maven/Maven.java
index 69f9fca..665da6c 100644
--- a/maven-core/src/main/java/org/apache/maven/Maven.java
+++ b/maven-core/src/main/java/org/apache/maven/Maven.java
@@ -31,6 +31,7 @@ import org.apache.maven.execution.MavenExecutionResult;
public interface Maven
{
@Deprecated
+ @SuppressWarnings( "checkstyle:constantname" )
String POMv4 = "pom.xml";
MavenExecutionResult execute( MavenExecutionRequest request );
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/MissingModuleException.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/MissingModuleException.java b/maven-core/src/main/java/org/apache/maven/MissingModuleException.java
index c920a6e..1bdf87a 100644
--- a/maven-core/src/main/java/org/apache/maven/MissingModuleException.java
+++ b/maven-core/src/main/java/org/apache/maven/MissingModuleException.java
@@ -21,6 +21,9 @@ package org.apache.maven;
import java.io.File;
+/**
+ * MissingModuleException
+ */
public class MissingModuleException
extends MavenExecutionException
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.java b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.java
index 01e6227..f7a5244 100644
--- a/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.java
+++ b/maven-core/src/main/java/org/apache/maven/ProjectDependenciesResolver.java
@@ -28,13 +28,13 @@ import org.apache.maven.artifact.resolver.ArtifactResolutionException;
import org.apache.maven.execution.MavenSession;
import org.apache.maven.project.MavenProject;
-@Deprecated
/**
* @deprecated As of 3.2.2, and there is no direct replacement. This is an internal class which was not marked as such,
* but should have been.
* @author jvanzyl
*
*/
+@Deprecated
public interface ProjectDependenciesResolver
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/factory/ArtifactFactory.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/artifact/factory/ArtifactFactory.java b/maven-core/src/main/java/org/apache/maven/artifact/factory/ArtifactFactory.java
index a16f64f..28f281e 100644
--- a/maven-core/src/main/java/org/apache/maven/artifact/factory/ArtifactFactory.java
+++ b/maven-core/src/main/java/org/apache/maven/artifact/factory/ArtifactFactory.java
@@ -22,7 +22,11 @@ package org.apache.maven.artifact.factory;
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.versioning.VersionRange;
+/**
+ * ArtifactFactory - deprecated
+ */
@Deprecated
+@SuppressWarnings( "checkstyle:parameternumber" )
public interface ArtifactFactory
{
@Deprecated
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/factory/DefaultArtifactFactory.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/artifact/factory/DefaultArtifactFactory.java b/maven-core/src/main/java/org/apache/maven/artifact/factory/DefaultArtifactFactory.java
index dfcac01..3ee65de 100644
--- a/maven-core/src/main/java/org/apache/maven/artifact/factory/DefaultArtifactFactory.java
+++ b/maven-core/src/main/java/org/apache/maven/artifact/factory/DefaultArtifactFactory.java
@@ -27,7 +27,12 @@ import org.apache.maven.artifact.versioning.VersionRange;
import org.codehaus.plexus.component.annotations.Component;
import org.codehaus.plexus.component.annotations.Requirement;
+/**
+ * DefaultArtifactFactory
+ *
+ */
@Component( role = ArtifactFactory.class )
+@SuppressWarnings( "checkstyle:parameternumber" )
public class DefaultArtifactFactory
implements ArtifactFactory
{
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/metadata/AbstractArtifactMetadata.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/artifact/metadata/AbstractArtifactMetadata.java b/maven-core/src/main/java/org/apache/maven/artifact/metadata/AbstractArtifactMetadata.java
index 5ef3a98..f0de677 100644
--- a/maven-core/src/main/java/org/apache/maven/artifact/metadata/AbstractArtifactMetadata.java
+++ b/maven-core/src/main/java/org/apache/maven/artifact/metadata/AbstractArtifactMetadata.java
@@ -21,6 +21,9 @@ package org.apache.maven.artifact.metadata;
import org.apache.maven.artifact.Artifact;
+/**
+ * AbstractArtifactMetadata
+ */
@Deprecated
public abstract class AbstractArtifactMetadata
extends org.apache.maven.repository.legacy.metadata.AbstractArtifactMetadata
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataRetrievalException.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataRetrievalException.java b/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataRetrievalException.java
index e419ef9..bef0268 100644
--- a/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataRetrievalException.java
+++ b/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataRetrievalException.java
@@ -21,6 +21,9 @@ package org.apache.maven.artifact.metadata;
import org.apache.maven.artifact.Artifact;
+/**
+ * Error while retrieving repository metadata from the repository - deprecated
+ */
@Deprecated
public class ArtifactMetadataRetrievalException
extends org.apache.maven.repository.legacy.metadata.ArtifactMetadataRetrievalException
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataSource.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataSource.java b/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataSource.java
index ccd5836..605230f 100644
--- a/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataSource.java
+++ b/maven-core/src/main/java/org/apache/maven/artifact/metadata/ArtifactMetadataSource.java
@@ -26,6 +26,10 @@ import org.apache.maven.artifact.repository.ArtifactRepository;
import org.apache.maven.artifact.versioning.ArtifactVersion;
import org.apache.maven.repository.legacy.metadata.MetadataResolutionRequest;
+/**
+ * Provides some metadata operations, like querying the remote repository for a list of versions available for an
+ * artifact - deprecated
+ */
@Deprecated
public interface ArtifactMetadataSource
extends org.apache.maven.repository.legacy.metadata.ArtifactMetadataSource
http://git-wip-us.apache.org/repos/asf/maven/blob/d9250817/maven-core/src/main/java/org/apache/maven/artifact/metadata/ResolutionGroup.java
----------------------------------------------------------------------
diff --git a/maven-core/src/main/java/org/apache/maven/artifact/metadata/ResolutionGroup.java b/maven-core/src/main/java/org/apache/maven/artifact/metadata/ResolutionGroup.java
index c219b24..3503265 100644
--- a/maven-core/src/main/java/org/apache/maven/artifact/metadata/ResolutionGroup.java
+++ b/maven-core/src/main/java/org/apache/maven/artifact/metadata/ResolutionGroup.java
@@ -26,6 +26,9 @@ import java.util.Set;
import org.apache.maven.artifact.Artifact;
import org.apache.maven.artifact.repository.ArtifactRepository;
+/**
+ * ResolutionGroup
+ */
@Deprecated
public class ResolutionGroup
extends org.apache.maven.repository.legacy.metadata.ResolutionGroup