You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "jaykay12 (via GitHub)" <gi...@apache.org> on 2026/05/14 20:26:42 UTC
[PR] SOLR-18239 : Fixed NPE during size estimator calculations [solr]
jaykay12 opened a new pull request, #4427:
URL: https://github.com/apache/solr/pull/4427
https://issues.apache.org/jira/browse/SOLR-18329
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
We appreciate transparent disclosure of significant [AI Coding assistants](https://github.com/apache/solr/blob/main/dev-docs/how-to-contribute.adoc#setup-for-contributing) usage.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
- [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #4427:
URL: https://github.com/apache/solr/pull/4427#discussion_r3244317085
##########
changelog/unreleased/SOLR-18239-fix-npe-size-estimator.yml:
##########
@@ -0,0 +1,31 @@
+# (DELETE ALL COMMENTS UP HERE AFTER FILLING THIS IN
Review Comment:
don't forget to do the clean up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "jaykay12 (via GitHub)" <gi...@apache.org>.
jaykay12 commented on code in PR #4427:
URL: https://github.com/apache/solr/pull/4427#discussion_r3244346056
##########
changelog/unreleased/SOLR-18239-fix-npe-size-estimator.yml:
##########
@@ -0,0 +1,31 @@
+# (DELETE ALL COMMENTS UP HERE AFTER FILLING THIS IN
Review Comment:
cleanup done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on code in PR #4427:
URL: https://github.com/apache/solr/pull/4427#discussion_r3244325615
##########
changelog/unreleased/SOLR-18239-fix-npe-size-estimator.yml:
##########
@@ -0,0 +1,31 @@
+# (DELETE ALL COMMENTS UP HERE AFTER FILLING THIS IN
+
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+
+# If the change is minor, don't bother adding a changelog entry.
+# For `other` type entries, the threshold to bother with a changelog entry should be even higher.
+
+# title:
+# * The audience is end-users and administrators, not committers.
+# * Be short and focused on the user impact. Multiple sentences is fine!
+# * For technical/geeky details, prefer the commit message instead of changelog.
+# * Reference JIRA issues like `SOLR-12345`, or if no JIRA but have a GitHub PR then `PR#12345`.
+
+# type:
+# `added` for new features/improvements, opt-in by the user typically documented in the ref guide
+# `changed` for improvements; not opt-in
+# `fixed` for improvements that are deemed to have fixed buggy behavior
+# `deprecated` for marking things deprecated
+# `removed` for code removed
+# `dependency_update` for updates to dependencies
+# `other` for anything else, like large/significant refactorings, build changes,
+# test infrastructure, or documentation.
+# Most such changes are too small/minor to bother with a changelog entry.
+
+title: Fix NPE in size estimator for null valued fields
+type: other
Review Comment:
`fixed` i suspect!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "jaykay12 (via GitHub)" <gi...@apache.org>.
jaykay12 commented on PR #4427:
URL: https://github.com/apache/solr/pull/4427#issuecomment-4461984505
Not sure, why the CI checks are failing for these 4 tests. [link](https://github.com/apache/solr/actions/runs/25888377807/job/76188100299?pr=4427)
<img width="1199" height="614" alt="Screenshot 2026-05-15 at 11 10 06 PM" src="https://github.com/user-attachments/assets/63636b57-3d14-4e9c-8a66-1308e63bc128" />
I tried running these tests individually on my setup, they works fine.
Running `./gradlew :solr:core:test` on local once to check for the entire suite. attaching its evidence shortly.
@epugh would you know why this would be happening in CI checks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #4427:
URL: https://github.com/apache/solr/pull/4427#discussion_r3249502405
##########
changelog/unreleased/SOLR-18239-fix-npe-size-estimator.yml:
##########
@@ -0,0 +1,7 @@
+title: Fixed NPE in size estimator for null valued fields
+type: other
+authors:
+ - name: Jalaz Kumar
+links:
+ - name: SOLR-18239
+ url: https://issues.apache.org/jira/browse/SOLR-18239
Review Comment:
PR description links to SOLR-18329, but this changelog entry (and the PR title) reference SOLR-18239. Please align the PR description/Jira reference so the correct issue is updated and release notes link to the intended ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4427:
URL: https://github.com/apache/solr/pull/4427#issuecomment-4462334899
thanks for trying..... So, Solr's tests are pretty dependent on timing and cpu... Crave runs them on a big box, and so sometimes thing fail.. Any number of tests can fail due to varitions in CI... Often if they fail, I will test them individually, and see if they fail using the seed value.... then that is a true bug.
you ran locally, and they passed, so that is pretty indicative that things are good.
We actualy use various tools including https://develocity.apache.org/scans/tests?search.relativeStartTime=P90D&search.rootProjectNames=solr*&search.timeZoneId=America%2FNew_York to detect which tests are flaky... And then try and improve them. It's on ongoing battle!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4427:
URL: https://github.com/apache/solr/pull/4427#issuecomment-4460188942
This all looks good to me, and I'm inclined to merge it when I get a good tests run. The only thing I wonder about, and this is my lack of overall knowledge, is that while we are fixing the NPE, is there any chance that the fact that you can get an NPE implies a bug or issue furthur up the process? How does a field come in that has a null value? Is that acceptable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4427:
URL: https://github.com/apache/solr/pull/4427#issuecomment-4462407800
> This all looks good to me, and I'm inclined to merge it when I get a good tests run. The only thing I wonder about, and this is my lack of overall knowledge, is that while we are fixing the NPE, is there any chance that the fact that you can get an NPE implies a bug or issue furthur up the process? How does a field come in that has a null value? Is that acceptable?
LLM helped me confirm that yes, lots of places a field value can be null!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "jaykay12 (via GitHub)" <gi...@apache.org>.
jaykay12 commented on PR #4427:
URL: https://github.com/apache/solr/pull/4427#issuecomment-4454920936
> just a bit of tidying needed, and of course ci checks.
tidying up ✅
since I have raised the PR from fork, 3 such CI checks are awaiting approval for trigger from maintainer community, please approve those workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "jaykay12 (via GitHub)" <gi...@apache.org>.
jaykay12 commented on code in PR #4427:
URL: https://github.com/apache/solr/pull/4427#discussion_r3244347496
##########
changelog/unreleased/SOLR-18239-fix-npe-size-estimator.yml:
##########
@@ -0,0 +1,31 @@
+# (DELETE ALL COMMENTS UP HERE AFTER FILLING THIS IN
+
+# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
+
+# If the change is minor, don't bother adding a changelog entry.
+# For `other` type entries, the threshold to bother with a changelog entry should be even higher.
+
+# title:
+# * The audience is end-users and administrators, not committers.
+# * Be short and focused on the user impact. Multiple sentences is fine!
+# * For technical/geeky details, prefer the commit message instead of changelog.
+# * Reference JIRA issues like `SOLR-12345`, or if no JIRA but have a GitHub PR then `PR#12345`.
+
+# type:
+# `added` for new features/improvements, opt-in by the user typically documented in the ref guide
+# `changed` for improvements; not opt-in
+# `fixed` for improvements that are deemed to have fixed buggy behavior
+# `deprecated` for marking things deprecated
+# `removed` for code removed
+# `dependency_update` for updates to dependencies
+# `other` for anything else, like large/significant refactorings, build changes,
+# test infrastructure, or documentation.
+# Most such changes are too small/minor to bother with a changelog entry.
+
+title: Fix NPE in size estimator for null valued fields
+type: other
Review Comment:
updated to `fixed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "jaykay12 (via GitHub)" <gi...@apache.org>.
jaykay12 commented on code in PR #4427:
URL: https://github.com/apache/solr/pull/4427#discussion_r3249765614
##########
changelog/unreleased/SOLR-18239-fix-npe-size-estimator.yml:
##########
@@ -0,0 +1,7 @@
+title: Fixed NPE in size estimator for null valued fields
+type: other
+authors:
+ - name: Jalaz Kumar
+links:
+ - name: SOLR-18239
+ url: https://issues.apache.org/jira/browse/SOLR-18239
Review Comment:
it was a miss from my side, when adding ticket number in PR description, have corrected now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18239: Fixed NPE during size estimator calculations [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #4427:
URL: https://github.com/apache/solr/pull/4427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org