[jira] [Commented] (HDFS-3131) Improve TestStorageRestore

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237314#comment-13237314 ] 

Hadoop QA commented on HDFS-3131:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12519752/HDFS-3131.branch-1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2087//console

This message is automatically generated.
                
> Improve TestStorageRestore
> --------------------------
>
>                 Key: HDFS-3131
>                 URL: https://issues.apache.org/jira/browse/HDFS-3131
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.24.0, 1.1.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Brandon Li
>            Priority: Minor
>              Labels: newbie
>         Attachments: HDFS-3131.branch-1.patch, HDFS-3131.patch
>
>
> Aaron has the following comments on TestStorageRestore in HDFS-3127.
> # removeStorageAccess, restoreAccess, and numStorageDirs can all be made private
> # numStorageDirs can be made static
> # Rather than do set(Readable/Executable/Writable), use FileUtil.chmod(...).
> # Please put the contents of the test in a try/finally, with the calls to shutdown the cluster and the 2NN in the finally block.
> # Some lines are over 80 chars.
> # No need for the numDatanodes variable - it's only used in one place.
> # Instead of "xwr" use "rwx", which I think is a more common way of describing permissions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira