You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jcesarmobile <gi...@git.apache.org> on 2014/10/25 00:43:45 UTC
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39
Fix CB-7734. Changed plugin to use UIAlertController on iOS 8
Changed plugin to use UIAlertController on iOS 8 and greater instead of
the UIAlertView as UIAlertView is deprecated now.
It makes the message scrollable if the text is too long (CB-7734)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-dialogs master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit c62e1b2a828108aa740f1819dc89cfb715422079
Author: Julio César <jc...@gmail.com>
Date: 2014-10-24T22:38:06Z
Changed plugin to use UIAlertController on iOS 8
Changed plugin to use UIAlertController on iOS 8 and greater instead of
the UIAlertView.
It makes the message scrollable is the text is too long.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91715099
Unfortunately after testing, it crashes on a prompt test on iOS 8. iOS 7 it passes alert, confirm, and prompt tests.
I used from the README:
```
function onPrompt(results) {
alert("You selected button number " + results.buttonIndex + " and entered " + results.input1);
}
navigator.notification.prompt(
'Please enter your name', // message
onPrompt, // callback to invoke
'Registration', // title
['Ok','Exit'], // buttonLabels
'Jane Doe' // defaultText
);
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94505096
I've just added the changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63144935
[UIAlertController class] doesn't crash on iOS 7 devices if you compile it on xcode 6 using iOS 8 SDK.
I'm making the changes for Xcode 5 right now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94154670
If been looking into your test project and the last commented line should be alertController.view.frame = alertFrame; not alertController.view.frame = [UIScreen mainScreen].applicationFrame; so it works on landscape on iPhone/iPod, my latest commit already have that line changed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94105276
I'm testing on Xcode 6.3 too, that's strange, can you test on a real device with 8.1 or 8.2? can you test on a 8.1 simulator?
can you repo the bug with the latest version of the plugin without my fix?
do you rotate the device before trying to scroll (once the alert appears)? that fixes the bug
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91721145
Remove this line, and prompt works on iOS 8: https://github.com/jcesarmobile/cordova-plugin-dialogs/blob/6b59babafeb8f1e7313ed99ea1625f839898e4ed/src/ios/CDVNotification.m#L50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94087506
This: "with the code on my pull request removing this line:
alertController.view.frame = [[UIScreen mainScreen] applicationFrame];"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91824100
@shazron iOS 8.3 already fix the too many words issue, so, not sure how to proceed here. Should we just expect everybody update their device and mark the issue as fixed?
Or should I add this line to fix it on previous versions and avoid the crash on iOS 8.3?
```
if ([[[UIDevice currentDevice] systemVersion] floatValue] < 8.3) {
alertController.view.frame = [[UIScreen mainScreen] applicationFrame];
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91790210
That line fixes the too many words issue, but if it crashes on iOS 8.3 I'll try to find another fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91768688
hi @shazron and @ginamdar
so...
what the next step about this bug fix progress
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by ginamdar <gi...@git.apache.org>.
Github user ginamdar commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-65650770
im not using text fields inside my projects but this works with dialogboxes on iOS8 without inputs fields
if (![self isAlertViewSupported]) {
CDVAlertViewController *alert = [CDVAlertViewController alertControllerWithTitle:title
message:message
preferredStyle:UIAlertControllerStyleAlert];
alert.alertViewCtrlCallBackId = callbackId;
NSUInteger count = [buttons count];
for (int n = 0; n < count; n++) {
UIAlertAction *actionWithTitle = [UIAlertAction actionWithTitle:[buttons objectAtIndex:n]
style:UIAlertActionStyleDefault
handler:^(UIAlertAction *action) {
CDVPluginResult* result;
UITextField *textField = [alert.textFields firstObject];
if (textField) {
NSString *value0 = textField.text;
NSDictionary* info = @{
@"buttonIndex":@(n),
@"input1":(value0 ? value0 : [NSNull null])
};
result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK
messageAsDictionary:info];
}else{
result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK
messageAsInt:(int)(n + 1)];
}
[self.commandDelegate sendPluginResult:result
callbackId:alert.alertViewCtrlCallBackId];
}];
[alert addAction:actionWithTitle];
}
if ([dialogType isEqualToString:DIALOG_TYPE_PROMPT]) {
[alert addTextFieldWithConfigurationHandler:^(UITextField *textField) {
textField.placeholder = defaultText ;
}];
}
[self.viewController presentViewController:alert animated:YES completion:nil];
}else{
//existing ios7 and older code?
}
- (BOOL)isAlertViewSupported
{
if([[UIDevice currentDevice].systemVersion compare:@"8.0" options:NSNumericSearch] == NSOrderedDescending){
return NO;
}else{
return YES;
}
}
...
@implementation CDVAlertViewController
@synthesize alertViewCtrlCallBackId;
@end
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94391292
Looks good to me. I'll pull it in in the morning, but this block could have been tightened up a bit: https://github.com/shazron/CB-7734/blob/882882c5fd03dd0a343e8ee8c85a362d40c82d48/platforms/ios/CB-7734/Plugins/cordova-plugin-dialogs/CDVNotification.m#L50-L62 but it's no biggie.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-67732478
hi @jcesarmobile @shazron @ginamdar
is there any specific time about this bug that merge into the official repository ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91827953
really thanks for @jcesarmobile and @shazron work hard !!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94087108
You mean without all the code on my pull request or with the code on my pull request removing this line:
alertController.view.frame = [[UIScreen mainScreen] applicationFrame];
?
On iOS 7 it should work because the bug only affects to iOS 8, and my code doesn't change anything for iOS 7, but I've been testing on iOS 8.1 and 8.2 simulators (almost everyone) and on real devices (iPod touch 8.2 and iPad 8.1.3) and I don't have scroll with you example if I remove that line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91795786
hi @jcesarmobile
thanks a lot
hope one day can solve this bug ~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63145321
In any case, NSClassFromString is the safest thing you can do, and is the best practice for supporting iOS 8-6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91827499
I've just found that the fix isn't working on iPhone/iPod touch when the device is in landscape, I'm going to update the code again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94396822
Don't merge it yet, I've just noticed that I'm comparing [[UIApplication sharedApplication] statusBarOrientation] with UIDeviceOrientation, and it should be UIInterfaceOrientation, I'll change it this afternoon and make tighten that block based on your recommendation but using statusBarOrientation, self.viewController.interfaceOrientation might not be reliable in some cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-87159454
hi @shazron
according to this
https://github.com/doggy8088/Learn-Git-in-30-days
seem everything fix done
so...please help...how long will merge into the official repository ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-68116655
thanks @shazron
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-76313015
hi @jcesarmobile @shazron @ginamdar
two months passed and new years come
so...
is this bug will merge into the official repository recently ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94611365
finally solved~
really thanks everybody's help !!!
I will waiting the new version release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94049313
Starting over again.
On iOS 8.2, and 7.1 Simulators -- I'm trying to make this "fail". Without your fix:
``` alertController.view.frame = [[UIScreen mainScreen] applicationFrame]; ``` when I add words greater than 1 page, it still scrolls for me?
I used this test case:
```
function dialogAlert() {
function alertDismissed() {
// do something
alert('dismissed');
}
var msg = "agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as" +
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"agj3kl3jtljsdgjl;sjlg;jsl;djglasjgl;jasl;gjlajgljaosgjsajg;aosgjpoagaspgkaokg;askg;kas;lgkasl;kgl;as"+
"END";
navigator.notification.alert(
msg, //'You are the winner!', // message
alertDismissed, // callback
'Game Over', // title
'Done' // buttonName
);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94089798
My assertion is, I can't repro the failing bug at all. I'm using Xcode 6.3, deploying to iOS 8.2 and 7.1 Simulators.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by bau720123 <gi...@git.apache.org>.
Github user bau720123 commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63158994
I am the original post
https://issues.apache.org/jira/browse/CB-7734
well...
really thanks for @jcesarmobile and @shazron help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63145889
done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-93868240
I think for the landscape problem, you should do this instead: https://github.com/apache/cordova-plugin-statusbar/blob/2b3935af315034fdf6626a1010e91d3d8f4483f0/src/ios/CDVStatusBar.m#L179-L187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91715637
Probably related: http://stackoverflow.com/questions/29571502/ios-8-3-uialertcontroller-crashes-when-trying-to-add-a-textfield
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-63123720
Hi Julio,
I'm sure you will have followed the dev@ discussion by now.
Two changes are required, since you are using iOS 8 API code.
1. Change your use of `[UIAlertController class]` to `NSClassFromString(@"UIAlertController")`. On iOS devices < iOS 8 your code will crash.
2. Wrap the whole code block with iOS 8 code with `#ifdef __IPHONE_8_0`. This way people using the Xcode 5 (which is still allowed by Apple) will not have compilation errors.
I would test the adjusted code out on an iOS 7 and iOS 8 device, and compile using Xcode 5 and 6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-68110398
Prob after the holidays :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-93894696
No, I've just tried and doesn't work if I do it that way (alertController.view.frame = [self invertFrameIfNeeded:[UIScreen mainScreen].applicationFrame orientation:[[UIApplication sharedApplication] statusBarOrientation]];)
That code doesn't invert if it's on iOS 8, but the thing is, it needs the inversion to make the text scroll
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-dialogs/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94176996
Actually the test project was just to repro the failing case. I haven't
evaluated your full landscape fix yet.
On Saturday, April 18, 2015, Julio César <no...@github.com> wrote:
> If been looking into your test project and the last commented line should
> be alertController.view.frame = alertFrame; not alertController.view.frame
> = [UIScreen mainScreen].applicationFrame; so it works on landscape on
> iPhone/iPod, my latest commit already have that line changed
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94154670>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by ginamdar <gi...@git.apache.org>.
Github user ginamdar commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-91729644
sorry for replying so late i never submitted PR for this and i have been using my own implementation and not updated the plugin so far
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94106987
In preparing my test project: https://github.com/shazron/CB-7734
I had to remove the build artifacts folder, and I did a re-test. Now I can repro your issue, not sure what was going on there :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org