[GitHub] [superset] john-bodley commented on pull request #23387: fix(sql lab): Tracking URL getter/setter

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on PR #23387:
URL: https://github.com/apache/superset/pull/23387#issuecomment-1473271519

   @ktmud if that's the case then rather than augmenting the `tracking_url` (via a getter/setter method)which corresponds to an actual column in the table (which likely adds to some level of confusion, i.e., I was tripped on this), why not move the logic which resides in, 
   
   ```python
   @property
   def tracking_url(self) -> Optional[str]:
    ...
   ```
   
   to a different property, maybe `tracking_url_transformed` and expose that to the frontend for rendering purposes?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org