[GitHub] ejona86 commented on issue #1637: Shutdown channel and notify when service unavailable

[GitBox <gi...@apache.org>]

ejona86 commented on issue #1637: Shutdown channel and notify when service unavailable
URL: https://github.com/apache/incubator-skywalking/pull/1637#issuecomment-419487194
 
 
   > If I do managedChannel#shutdownNow, will ongoing StreamObserver(belong to this channel) do onError?
   
   Yes.
   
   > If yes, I think when service is unavailable at old address/port, I should kill the old connection.
   
   It looks like the list of addresses is constant. Yes, you could remove one. But it seems like you have a problem that you won't learn of any new backends; eventually you won't have any backends.
   
   In general, I'd suggest to create a `NameResolver` that parses `BACKEND_SERVICE` and returns the list of all backends. Then gRPC will try each in turn. But it seems like you need to resolve the fact that the backends change but the system won't learn about them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services